feat(errors): Turn manualy raised unprocessable_entity errors into ValidationFailure #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
added
API
rsempe
approved these changes
Sep 15, 2022
lovrocolic
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Error handling in services and the way it's rendered in API and GraphQL needs a complete refactoring.
Description
The objective of this pull request is to normalize the way services return data validation errors.
When a service action cannot be performed because the custom pre-conditions are not met, the service keeps returning a failed error as it was doing before. But instead of a list of error codes and custom "unprocessable entity we are now building a
BaseService::ValidationFailurewith a list of error messages for each fields (or base if not for a specific field) and we attach it as the error field of the result object.This new behavior is now used in the custom service validators
NOTE: The result of wallet validators changed a bit, it as an impact on the front end and should be fixed before the merge