Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid catching ActiveStorage routes with catch_all #448

Merged
merged 1 commit into from
Sep 13, 2022
Merged

fix: Avoid catching ActiveStorage routes with catch_all #448

merged 1 commit into from
Sep 13, 2022

Conversation

vincent-pochet
Copy link
Collaborator

@vincent-pochet vincent-pochet commented Sep 13, 2022 •
edited
Loading

Hotfix to avoid catching inner ActiveStorage routes with the "Catch all" route added to render json 404

@vincent-pochet vincent-pochet added the 🐞 Bug Something isn't working label Sep 13, 2022
@vincent-pochet vincent-pochet self-assigned this Sep 13, 2022
@vincent-pochet vincent-pochet merged commit 620ba2b into main Sep 13, 2022
@vincent-pochet vincent-pochet deleted the fix/catch-all-route branch September 13, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdenquin jdenquin jdenquin approved these changes

Assignees

@vincent-pochet vincent-pochet

Labels
🐞 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @jdenquin