Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memberships: list and revoke #436

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Memberships: list and revoke #436

merged 3 commits into from
Sep 6, 2022

Conversation

ansmonjol
Copy link
Collaborator

@ansmonjol ansmonjol commented Sep 5, 2022 •
edited
Loading

This PR is included in the scope of the "invite memberships" feature.
This is the first part out of three:

  1. Memberships: list and revoke 👈 we are here
  2. Invites: list, create and revoke
  3. Accept invite

This PR adds

  • Query memberships of an organization
  • Revoke a member of an organization

@ansmonjol ansmonjol added Feature Add a new feature to the app GraphQL Related to the GraphQL API labels Sep 5, 2022
@ansmonjol ansmonjol self-assigned this Sep 5, 2022
vincent-pochet
vincent-pochet reviewed Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but looks good! 💪 🚀

db/migrate/20220905095454_add_membership_status_and_revoked_at.rb Outdated Show resolved Hide resolved
@ansmonjol ansmonjol force-pushed the membership-list-and-revoke branch from dc8e1d3 to fd94eea Compare September 6, 2022 07:01
rsempe
rsempe reviewed Sep 6, 2022
View reviewed changes
app/models/membership.rb Outdated Show resolved Hide resolved
@ansmonjol ansmonjol force-pushed the membership-list-and-revoke branch from fd94eea to 30660a3 Compare September 6, 2022 09:08
@ansmonjol ansmonjol force-pushed the membership-list-and-revoke branch 2 times, most recently from 5312065 to 04ddebb Compare September 6, 2022 09:19
rsempe
rsempe reviewed Sep 6, 2022
View reviewed changes
spec/models/membership_spec.rb Outdated Show resolved Hide resolved
app/services/memberships/revoke_service.rb Outdated Show resolved Hide resolved
app/services/memberships/revoke_service.rb Outdated Show resolved Hide resolved
spec/services/memberships/revoke_service_spec.rb Outdated Show resolved Hide resolved
app/services/memberships/revoke_service.rb Outdated Show resolved Hide resolved
spec/services/memberships/revoke_service_spec.rb Outdated Show resolved Hide resolved
spec/services/memberships/revoke_service_spec.rb Outdated Show resolved Hide resolved
app/services/memberships/revoke_service.rb Outdated Show resolved Hide resolved
@ansmonjol ansmonjol force-pushed the membership-list-and-revoke branch from 04ddebb to 40d2655 Compare September 6, 2022 12:20
@ansmonjol ansmonjol merged commit a919a54 into main Sep 6, 2022
@ansmonjol ansmonjol deleted the membership-list-and-revoke branch September 6, 2022 12:43
This was referenced Sep 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsempe rsempe rsempe approved these changes

@jdenquin jdenquin Awaiting requested review from jdenquin

@lovrocolic lovrocolic Awaiting requested review from lovrocolic

@vincent-pochet vincent-pochet Awaiting requested review from vincent-pochet

Assignees

@ansmonjol ansmonjol

Labels
Feature Add a new feature to the app GraphQL Related to the GraphQL API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansmonjol @rsempe @vincent-pochet