Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subscription anniversary date with trial amount #422

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix: Subscription anniversary date with trial amount #422

merged 1 commit into from
Aug 31, 2022

Conversation

jdenquin
Copy link
Contributor

Context

  • When using a trial period with a pay in advance plan, with an anniversary subscription, the daily price is wrong.

Description

  • Use the correct date for daily price calculating.

We QAed it and it's all good now!

@jdenquin jdenquin added Subscription Relation to the Subscriptions 🐞 Bug Something isn't working labels Aug 31, 2022
@jdenquin jdenquin self-assigned this Aug 31, 2022
@jdenquin jdenquin merged commit 9a978f0 into main Aug 31, 2022
@jdenquin jdenquin deleted the fix-anniversary-with-trial branch August 31, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsempe rsempe rsempe approved these changes

@vincent-pochet vincent-pochet Awaiting requested review from vincent-pochet

@lovrocolic lovrocolic Awaiting requested review from lovrocolic

Assignees

@jdenquin jdenquin

Labels
🐞 Bug Something isn't working Subscription Relation to the Subscriptions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdenquin @rsempe