Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Use external_id instead of customer_id and subscription_id #419

Merged
merged 9 commits into from
Sep 5, 2022
Merged

misc: Use external_id instead of customer_id and subscription_id #419

merged 9 commits into from
Sep 5, 2022

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Aug 30, 2022

Context

We want to clarify the difference between lago ids and external ids.

Today, we have customer_id on customers and subscription_id|unique_id on subscriptions.

On the API, the goal is to use external_ids:

  • external_id or external_customer_id for customer
  • external_id or external_subscription_id for subscription

Description

The goal of this PR is to:

  • rename customer_id to external_id on customers
  • rename subscription_id to external_id on subscriptions
  • remove unique_id from subscriptions

vincent-pochet
vincent-pochet approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

db/schema.rb Show resolved Hide resolved
app/services/subscriptions/create_service.rb Show resolved Hide resolved
app/services/invoices/customer_usage_service.rb Show resolved Hide resolved
app/services/payment_provider_customers/create_service.rb Outdated Show resolved Hide resolved
@rsempe rsempe force-pushed the subscription-id branch 6 times, most recently from 01857f7 to 2b8a179 Compare September 1, 2022 14:14
@vincent-pochet vincent-pochet mentioned this pull request Sep 2, 2022
Merged
@rsempe rsempe force-pushed the subscription-id branch 3 times, most recently from e8c71d8 to c7c169c Compare September 2, 2022 09:05
@rsempe rsempe merged commit f93a5e3 into main Sep 5, 2022
@rsempe rsempe deleted the subscription-id branch September 5, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsempe @vincent-pochet