feat: Add validation logic for the volume charge model #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
changed the title
lovrocolic
approved these changes
Aug 22, 2022
rsempe
reviewed
Aug 22, 2022
rsempe
reviewed
Aug 22, 2022
rsempe
reviewed
Aug 22, 2022
rsempe
reviewed
Aug 22, 2022
vincent-pochet
force-pushed
the
feature/volume-charge-model-definition
branch
from
89bf101 to
2b8cd1d
Compare
rsempe
approved these changes
Aug 22, 2022
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to introduce a new charge model to charge users based on a consumed volume.
The existing graduated pricing does not fit this need because it creates tier, and each tier has its own price.
The volume price works differently, it creates tiers, but the whole number of units is multiplied by the current tier. Then, the number of units consumed determine the total price for each unit.
Description
This pull request is the first step of the volume pricing charge model.
It adds the logic to validate a charge with a
volumecharge model.