fix(stripe): ensure payment method is up to date #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
changed the title
rsempe
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Stripe integration is missing the payment method cleanup webhook and does not checks for the validity of the registered payment method
Description
If a payment method is removed from a customer on stripe dashboard, or via an API call, Lago application does not know about it and will try to use it for future payment.
This PR includes two fixes:
payment_method.detachedStripe webhook to cleanupPaymentProviderCustomers::StripeCustomer payment_method_id fieldwhen a payment method is removed on Stripe sideHow Has This Been Tested?
A Complete QA will be performed both locally and on a staging branch