fix: Fix boundaries for full period payed in advance #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With the new multiple plans feature, the issuing date of the invoice have been updated to be the previous day of the invoice generation.
Description
Before the change, in the case of a plan payed in advance, the issuing date was the invoice creation date and so the first day of the new invoice period.
The issuing date field was used to recompute bounds of the invoice in the case of a trial period.
Before:
After:
Also, the code was not taking the plan interval into account, it was only working with monthly interval... 🐞
Note: the bounds computation will be delegated to a proper date service with the coming anniversary date feature
How Has This Been Tested?
QA have been performed locally