Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ability to create fee with negative units or amount #2966

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Dec 17, 2024

We still have some invoices stuck in generating status, when units or amount are negative.

The goal of this PR is to permit the creation of the fee by converting the value to 0 when it's negative for units and amount fields.

But we keep the calculation details on amount_details.

Example:
Screenshot 2024-12-17 at 10 12 46

@rsempe rsempe added the 🐞 Bug Something isn't working label Dec 17, 2024
@rsempe rsempe merged commit 8dda07a into main Dec 17, 2024
6 checks passed
@rsempe rsempe deleted the fix/generating-invoices branch December 17, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants