fix: Ensure consistent order of results on list responses (frontend and API) #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures consistent ordering of returned credit notes
as this is going to be applied accross all query objects, extract the ordering to the base class
Why is this one ordering by created_at asc instead of created_at desc?
also restyle specs
this was not really required as the ordering field webhook_url was already unique...
on plans index to include pending for deletion plans
ensure responses are consistent and have a consistent ordering
and keep the same data as before with the new inclusion of pending for deletion plans added to the query object
add wallets query object with filter validation
ancorcruz
changed the title
vincent-pochet
approved these changes
Dec 12, 2024
This reverts commit c57573b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some endpoints like
GET /api/v1/credit_notesprovide duplicate results on pagination as created_at is not accurate enough to effectively order resources by itself.Description
This change updates all API/v1 controllers to use query objects to retrieve records for the
GET / (index)endpoints. Also, apply default ordering by created_at :desc and id :asc to ensure records stay in their position when going through pages.Query classes specs are re-styled to the current rules we are following.