bug(ProgressiveBilling) - manually created credit notes interfere with progressive billing credits. #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
changed the title
nudded
force-pushed
the
bug-progressive-billing-with-existing-invoices
branch
from
f562e6b to
3f37697
Compare
…ssive billing invoices
nudded
force-pushed
the
bug-progressive-billing-with-existing-invoices
branch
from
3f37697 to
6995e87
Compare
vincent-pochet
approved these changes
Dec 5, 2024
nudded
force-pushed
the
bug-progressive-billing-with-existing-invoices
branch
from
d1a0410 to
01b2968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calculating the progressive billing invoice credit to apply, we don't take into account that a) this invoice might already be credited and there could also be credit notes created for this invoice.
This PR address both. As a bonus it also fixes a credit note item validator