Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust fee serializer for pay in advance fees #2914

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

lovrocolic
Copy link
Collaborator

Context

In some scenarios, there was no event_transaction_id attached in fee serializer

Description

This PR simplifies method in serializer and ensure presence of event_transaction_id value

Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@lovrocolic lovrocolic merged commit 1b007db into main Dec 5, 2024
6 checks passed
@lovrocolic lovrocolic deleted the fix-fee-serializer branch December 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants