Bug(Events) - make sure to cleanup clickhouse events after billable metric removal #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
force-pushed
the
bug-delete-events-clickhouse
branch
from
b8c5218 to
3c7df48
Compare
nudded
force-pushed
the
bug-delete-events-clickhouse
branch
from
3c7df48 to
ea0a9ea
Compare
|
CH hates deletion, but that make sense! |
jdenquin
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
We recently fixed the case where events were not correctly removed for new-style subscriptions (using
external_subscription_id). We forgot about clickhouse events, this PR fixes that and will also remove those.