Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dunning): Reset customers last attempt on dunning campaign deletion #2840

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Nov 21, 2024

Roadmap Task

👉 https://getlago.canny.io/feature-requests/p/set-up-payment-retry-logic

👉 https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices

Context

We want to automate dunning process so that our users don't have to look at each customer to maximize their chances of being paid retrying payments of overdue balances and sending email reminders.

We are extending dunning campaigns management to edit and delete campaigns.

Description

This change adds the ability to reset last attempt on customers when deleting a dunning campaign.

Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question on where to put the code.

app/models/dunning_campaign.rb Show resolved Hide resolved
app/models/dunning_campaign.rb Outdated Show resolved Hide resolved
app/models/dunning_campaign.rb Show resolved Hide resolved
@rsempe rsempe force-pushed the feat/auto-dunning-delete branch from 824e228 to cd6d978 Compare November 22, 2024 13:22
@rsempe rsempe force-pushed the feat/auto-dunning-delete branch from d11f8f3 to 102679f Compare November 22, 2024 13:37
app/services/dunning_campaigns/create_service.rb Outdated Show resolved Hide resolved
app/services/dunning_campaigns/update_service.rb Outdated Show resolved Hide resolved
@rsempe rsempe force-pushed the feat/auto-dunning-delete branch from 60fb3f9 to 985268e Compare November 22, 2024 14:40
@ancorcruz
Copy link
Contributor

:shipit:

@ancorcruz ancorcruz merged commit 09d0017 into main Nov 22, 2024
6 checks passed
@ancorcruz ancorcruz deleted the feat/auto-dunning-delete branch November 22, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants