-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dunning): Add DunningCampaign resolver to graphql api #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
reviewed
Nov 20, 2024
rsempe
reviewed
Nov 20, 2024
rsempe
reviewed
Nov 20, 2024
rsempe
reviewed
Nov 20, 2024
## Roadmap Task 👉 https://getlago.canny.io/feature-requests/p/set-up-payment-retry-logic 👉 https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices ## Context We want to automate dunning process so that our users don't have to look at each customer to maximize their chances of being paid retrying payments of overdue balances and sending email reminders. We are extending dunning campaigns management to edit and delete campaigns. ## Description This change adds a new resolver to graphql api to retrieve a single dunning campaign by id. This is required to render the dunning campaign edit screen in the frontend side.
as we use softdeletion with discard gem, this does not handle rails counter cache columns, this change ensures the counter cache column is updated when a customer is discarded or undiscarded
ancorcruz
force-pushed
the
feat/dunning-edit-campaign-resolver
branch
from
November 20, 2024 14:37
101255e
to
d849a84
Compare
This reverts commit d849a84.
This reverts commit e8c4282.
This reverts commit 3f48f6b.
we need also to aggregate all customer falling back to the campaign if this is the organization's default
this includes customers with the campaign assigned explicitly and also customers with the campaign as organization defaults' when the campaign is applied to the organization
rsempe
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/set-up-payment-retry-logic
👉 https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices
Context
We want to automate dunning process so that our users don't have to look at each customer to maximize their chances of being paid retrying payments of overdue balances and sending email reminders.
We are extending dunning campaigns management to edit and delete campaigns.
Description
This change adds a new resolver to graphql api to retrieve a single dunning campaign by id. This is required to render the dunning campaign edit screen in the frontend side.
Also adds counter cache customers_count on dunning campaigns customer relationship to provide a performant count of customers with the dunning campaign applied.