fix(stripe): Handle missing payment #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
fix-missing-payments
branch
3 times, most recently
from
f7f6101 to
68875ac
Compare
vincent-pochet
force-pushed
the
fix-missing-payments
branch
from
68875ac to
f876c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some
PaymentProviders::Stripe::HandleEventJobwith 'payment_intent.payment_failed' or 'payment_intent.succeeded' event type are failing withBaseService::NotFoundFailure - stripe_payment_not_found.The webhook contains metadata of lago's invoices but the related
Paymentcannot be found in the database. It is probably because the job creating the stripe payment was killed allong with the worker running it under heavy load.Description
This PR changes the logic to re-create the
Paymentrecord when missing using the data from the webhook object. It will allow to update theinvoice.payment_statusaccordingly