Bug(PayInAdvanceFee) - fix grouped_by logic for Fees::CreatePayInAdvanceService #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
force-pushed
the
bug-fix-grouped_by-fetching-for-pay-in-advance
branch
from
8105066 to
aff8782
Compare
nudded
force-pushed
the
bug-fix-grouped_by-fetching-for-pay-in-advance
branch
from
aff8782 to
e841cae
Compare
vincent-pochet
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
grouped_by can be stored on charge filters. This PR caches the properties so we're using the correct ones in the service.