Fix(anrok): return zero-tax breakdown if client facing taxes sum is 0 #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
changed the title
annvelents
changed the title
ivannovosad
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If taxes are payable by seller, line_items.tax_amount_cents will be 0, but tax_breakdown might be not 0 (these taxes the seller will pay), so we don't need to create applied taxes if in taxes returned from the tax provider, the tax_amount_cents of the line_item is 0
Description
updated
Invoice::ApplyProviderTaxesandFee::ApplyProviderTaxesto create zero-taxes if fee.tax_amount_cents is 0, but tax_breakdown contains some taxes;