fix(adyen): Improve webhook handling with missing code #2714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is related to the
BaseService::ServiceFailure - payment_provider_code_missing: Code is missing
raised by theWebhooksController#adyen
endpoint.The API is raising a lot of these error that are related to a wrong configuration of the Adyen webhook URL.
When an organization has multiple Adyen account configured, the webhook call must contain a code parameter. When this value is missing the call just end with an
HTTP 500
error.Description
Since nothing can be do to remediate the situation on Lago's side and it is generating a lot of noise, this PR handle this kind of error to keep notifying Adyen that the webhook was not succesfully handled (Bad Request response) but is avoiding the
HTTP 500
error and the related Sentry issueList any dependencies that are required.