fix(clickhouse): Fix timestamp precision #2689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on optimizing timestamp precision in the
unique_count_query.rb
file by adjusting the precision level in various SQL queries. The changes include modifying thetoDateTime64
function to use a precision of 3 instead of 5 across different methods.Timestamp precision adjustments:
app/services/events/stores/clickhouse/unique_count_query.rb
: Changed the precision in theevents_cte_sql
method to usetimestamp
directly instead oftoDateTime64(timestamp, 5, 'UTC')
.app/services/events/stores/clickhouse/unique_count_query.rb
: Updated thegrouped_events_cte_sql
method to usetimestamp
directly instead oftoDateTime64(timestamp, 5, 'UTC')
.app/services/events/stores/clickhouse/unique_count_query.rb
: Modified theperiod_ratio_sql
method to usetoDateTime64
with a precision of 3 instead of 5 for thefrom_datetime
andto_datetime
parameters.app/services/events/stores/clickhouse/unique_count_query.rb
: Adjusted thegrouped_period_ratio_sql
method to usetoDateTime64
with a precision of 3 instead of 5 for thefrom_datetime
andto_datetime
parameters.