Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: credit note on credit invoice - estimate service #2687

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Feat: credit note on credit invoice - estimate service #2687

merged 8 commits into from
Oct 21, 2024

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented Oct 14, 2024 •
edited
Loading

Adding a possibility to estimate credit note on prepaid credit invoice:

  • allow credit note for credit invoices
  • credited amount for credit invoices is 0
  • refund amount for credit invoices is not bigger than available wallet balance

@annvelents annvelents force-pushed the feat-credit-note-on-credit-estimate branch from 8a38885 to a275313 Compare October 15, 2024 13:28
@annvelents annvelents force-pushed the feat-credit-note-on-credit-estimate branch from a275313 to 393e419 Compare October 15, 2024 13:40
@annvelents annvelents marked this pull request as ready for review October 15, 2024 14:03
vincent-pochet
vincent-pochet approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@annvelents annvelents merged commit c393c01 into main Oct 21, 2024
6 checks passed
@annvelents annvelents deleted the feat-credit-note-on-credit-estimate branch October 21, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annvelents @vincent-pochet