Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(invoice-numbering): cover draft invoice number when tax error #2671

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(invoice-numbering): cover draft invoice number when tax error #2671

merged 2 commits into from
Oct 11, 2024

Conversation

lovrocolic
Copy link
Collaborator

Context

Recently one refactoring around invoice numbering was introduced.

Description

This PR ensures that draft invoice number is attached when status is failed

@lovrocolic lovrocolic changed the title fix: cover draft invoice number when tax error fix(invoice-numbering): cover draft invoice number when tax error Oct 11, 2024
@lovrocolic lovrocolic merged commit 9cee963 into main Oct 11, 2024
6 checks passed
@lovrocolic lovrocolic deleted the cover-draft-invoice-number branch October 11, 2024 08:42
@lovrocolic lovrocolic mentioned this pull request Oct 14, 2024
Merged
lovrocolic added a commit that referenced this pull request Oct 14, 2024
@lovrocolic
fix (invoice-numbering): revert draft case for new invoice numbering (#…
096f5e3 
…2683)

## Description

This PR reverts #2671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovrocolic @vincent-pochet