Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(groupe-by): Ensure all groups appears on invoice #1724

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix(groupe-by): Ensure all groups appears on invoice #1724

merged 1 commit into from
Feb 26, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Context

Invoice pdf do not display the correct fee when grouped_by

How to reproduce issue?

  1. I created a plan.charge with grouped_by attribute
  2. I created a subscription on customer
  3. Sends events to this subscription with grouped_by.key values
  4. Current usage is displayed correctly ✅
  5. I terminate the subscription
  6. Invoice on user interface is displayed correctly ✅
  7. Invoice on PDF display only 1 fees (looks like it aggregates all fees into one) ❌

Description

The fix is to ensure that we loop over all fees when rendering the invoice

@vincent-pochet vincent-pochet added Invoice Related to Invoices 🐞 Bug Something isn't working labels Feb 23, 2024
@vincent-pochet vincent-pochet self-assigned this Feb 23, 2024
@vincent-pochet vincent-pochet merged commit 36f5322 into main Feb 26, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the fix-grouped-by branch February 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovrocolic lovrocolic lovrocolic approved these changes

Assignees

@vincent-pochet vincent-pochet

Labels
🐞 Bug Something isn't working Invoice Related to Invoices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @lovrocolic