Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: small refactoring regarding caching and event stores #1691

Merged
merged 1 commit into from
Feb 13, 2024
Merged

misc: small refactoring regarding caching and event stores #1691

merged 1 commit into from
Feb 13, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Description

This PR adds:

  • The missing method signatures in the Events::Stores::BaseStore
  • Takes advantage of the Subscriptions::ChargeCacheService to generate the cache key in the current usage service

@vincent-pochet vincent-pochet self-assigned this Feb 12, 2024
@vincent-pochet vincent-pochet merged commit 284030e into main Feb 13, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the feat-add-missing-store-signatures branch February 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsempe rsempe rsempe approved these changes

@ivannovosad ivannovosad Awaiting requested review from ivannovosad

@jdenquin jdenquin Awaiting requested review from jdenquin

@lovrocolic lovrocolic Awaiting requested review from lovrocolic

Assignees

@vincent-pochet vincent-pochet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-pochet @rsempe