Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(group-by): add grouped_by_value logic to event stores #1617

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Context

Some customers have requested a way to group usage fees on an invoice using an event property. The same charge model properties should be applied to each group. The logic will only apply to standard charge model.

Description

This PR refactors the filtering arguments in the events store services:

  • Remove the unused event argument
  • Move the group argument as a sub value of a new filters one
  • Add grouped_by and grouped_by_value argument in the filters
  • Add logic to handle grouped_by_value when present

@vincent-pochet vincent-pochet added Event Related to Events 🐞 Bug Something isn't working labels Jan 19, 2024
@vincent-pochet vincent-pochet self-assigned this Jan 19, 2024
@vincent-pochet vincent-pochet force-pushed the feat-group-by-event-stores branch from c0ff257 to da50076 Compare January 19, 2024 15:11
@vincent-pochet vincent-pochet merged commit 45edf4d into main Jan 19, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the feat-group-by-event-stores branch January 19, 2024 15:38
@vincent-pochet vincent-pochet removed the 🐞 Bug Something isn't working label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event Related to Events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants