Make it possible to configure when subscription termination alert is sent by setting env var #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vincent Pochet <vincent@getlago.com>
Co-authored-by: Vincent Pochet <vincent@getlago.com>
Co-authored-by: Vincent Pochet <vincent@getlago.com>
|
Thank you @edwardmp for this pull request (and for applying the comments very quickly 😉 ). |
|
@vincent-pochet awesome! Thanks for reviewing. Pleasure doing business ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It's nice to make this configurable. e.g. in my case I want it sent 1 day before ending as well.
Description
By setting env var
LAGO_SUBSCRIPTION_TERMINATION_ALERT_SENT_AT_DAYSit can be overridden from the defaults.E.g.
LAGO_SUBSCRIPTION_TERMINATION_ALERT_SENT_AT_DAYSto1,30will cause it be sent 1 and 30 days in advance.