feat(edit-draft-invoice): Apply adjusted fee on subscription fee #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
force-pushed
the
apply-adjusted-fee-on-subscription-fee
branch
from
b38e688 to
b153d12
Compare
lovrocolic
force-pushed
the
apply-adjusted-fee-on-subscription-fee
branch
from
58d9731 to
8824079
Compare
vincent-pochet
approved these changes
Jan 11, 2024
lovrocolic
force-pushed
the
apply-adjusted-fee-on-subscription-fee
branch
from
fa25461 to
bd82dd4
Compare
lovrocolic
force-pushed
the
apply-adjusted-fee-on-subscription-fee
branch
from
bd82dd4 to
8225c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently it is not possible to manually edit the draft invoice through the UI. With this feature it will be possible to adjust fee, remove adjusted values and recalculate draft invoice based on those values.
Description
Refresh draft invoice action can be called anytime, and this action destroys all attached fees and rebuilds them again. In a similar way also works finalise draft invoice action. This PR ensures that with each rebuilding of fees we check if there is any adjusted fee and we apply it on related fee.