feat(event): Use generating invoice service for prepaid credit invoices #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
requested review from
rsempe,
ivannovosad,
jdenquin and
lovrocolic
rsempe
approved these changes
Dec 18, 2023
vincent-pochet
force-pushed
the
feat-credit-invoice
branch
from
0f48542 to
45fc936
Compare
lovrocolic
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR follows #1546
Description
It makes use of the new
Invoices::CreateGeneratingServiceservice in theInvoices::PaidCreditService, to reduce the risk of database locking when generating theorganization_sequential_idA logic to prevent duplication of
generatinginvoice was also added to theBillPaidCreditJob