fix(invoice): Finalize each invoice in a single job #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
requested review from
rsempe,
ivannovosad,
jdenquin and
lovrocolic
ivannovosad
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some
Clock::FinalizeInvoicesJobare failling with aBaseService::ValidationFailure: Validation errors: {:amount_cents=>["value_is_out_of_range"]}error.Since all invoices are processed in a single jobs, it's preventing all invoices from being finalized automatically.
Description
This PR does not fix the root cause of the failed job (we first have to identify with invoice is impacted) but it processing each invoice in its own job, to make sure that a failure on an invoice does not impact the other invoices