fix review

app/jobs/send_webhook_job.rb

@@ -7,10 +7,10 @@ class SendWebhookJob < ApplicationJob
 
   retry_on LagoHttpClient::HttpError, wait: :exponentially_longer, attempts: 3
 
-  def perform(webhook_type, object_id)
+  def perform(webhook_type, object)
     case webhook_type
     when :invoice
-      Webhooks::InvoicesService.new(object_id).call
+      Webhooks::InvoicesService.new(object).call
     else
       raise NotImplementedError
     end

app/services/invoices/create_service.rb

@@ -23,7 +23,7 @@ def create
 
         compute_amounts(invoice)
 
-        SendWebhookJob.perform_later(:invoice, invoice.id)
+        SendWebhookJob.perform_later(:invoice, invoice)
 
         result.invoice = invoice
       end

app/services/webhooks/base_service.rb

@@ -5,8 +5,8 @@
 module Webhooks
   # NOTE: Abstract Service, should not be used directly
   class BaseService
-    def initialize(object_id)
-      @object = find_object(object_id)
+    def initialize(object)
+      @object = object
     end
 
     def call
@@ -21,10 +21,6 @@ def call
 
     attr_reader :object
 
-    def find_object(object_id)
-      # Empty
-    end
-
     def object_serializer
       # Empty
     end

app/services/webhooks/invoices_service.rb

@@ -4,10 +4,6 @@ module Webhooks
   class InvoicesService < Webhooks::BaseService
     private
 
-    def find_object(object_id)
-      Invoice.find(object_id)
-    end
-
     def current_organization
       @current_organization ||= object.organization
     end

spec/jobs/send_webhook_job_spec.rb

@@ -9,19 +9,19 @@
 
   it 'calls the webhook invoice service' do
     allow(Webhooks::InvoicesService).to receive(:new)
-      .with(invoice.id)
+      .with(invoice)
       .and_return(webhook_invoice_service)
     allow(webhook_invoice_service).to receive(:call)
 
-    described_class.perform_now(:invoice, invoice.id)
+    described_class.perform_now(:invoice, invoice)
 
     expect(Webhooks::InvoicesService).to have_received(:new)
     expect(webhook_invoice_service).to have_received(:call)
   end
 
   context 'with not implemented webhook type' do
     it 'raises a NotImplementedError' do
-      expect { described_class.perform_now(:subscription, invoice.id) }
+      expect { described_class.perform_now(:subscription, invoice) }
         .to raise_error(NotImplementedError)
     end
   end

spec/services/webhooks/invoices_service_spec.rb

@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.describe Webhooks::InvoicesService do
-  subject(:webhook_invoice_service) { described_class.new(invoice.id) }
+  subject(:webhook_invoice_service) { described_class.new(invoice) }
 
   let(:organization) { create(:organization, webhook_url: 'http://foo.bar') }
   let(:subscription) { create(:subscription, organization: organization) }