fix(netsuite): Change params in the invoice payload (#2752)

## Description Change some of the params of invoice payload.
getlago · Oct 29, 2024 · b38a159 · b38a159
1 parent d8c51c8
commit b38a159
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 14 deletions.
diff --git a/app/services/integrations/aggregator/invoices/payloads/netsuite.rb b/app/services/integrations/aggregator/invoices/payloads/netsuite.rb
@@ -39,11 +39,10 @@ def body
 
           def columns
             result = {
-              'tranid' => invoice.id,
+              'tranid' => invoice.number,
               'entity' => integration_customer.external_customer_id,
               'taxregoverride' => true,
               'taxdetailsoverride' => true,
-              'otherrefnum' => invoice.number,
               'custbody_ava_disable_tax_calculation' => true,
               'custbody_lago_invoice_link' => invoice_url,
               'custbody_lago_id' => invoice.id,

diff --git a/spec/services/integrations/aggregator/invoices/create_service_spec.rb b/spec/services/integrations/aggregator/invoices/create_service_spec.rb
@@ -140,11 +140,10 @@
       'type' => 'invoice',
       'isDynamic' => true,
       'columns' => {
-        'tranid' => invoice.id,
+        'tranid' => invoice.number,
         'taxregoverride' => true,
         'taxdetailsoverride' => true,
         'entity' => integration_customer.external_customer_id,
-        'otherrefnum' => invoice.number,
         'custbody_lago_id' => invoice.id,
         'custbody_ava_disable_tax_calculation' => true,
         'custbody_lago_invoice_link' => invoice_url,

diff --git a/spec/services/integrations/aggregator/invoices/payloads/netsuite_spec.rb b/spec/services/integrations/aggregator/invoices/payloads/netsuite_spec.rb
@@ -237,11 +237,10 @@
       context 'when tax nexus is not present' do
         let(:columns) do
           {
-            'tranid' => invoice.id,
+            'tranid' => invoice.number,
             'entity' => integration_customer.external_customer_id,
             'taxregoverride' => true,
             'taxdetailsoverride' => true,
-            'otherrefnum' => invoice.number,
             'custbody_lago_id' => invoice.id,
             'custbody_ava_disable_tax_calculation' => true,
             'custbody_lago_invoice_link' => invoice_link,
@@ -325,11 +324,10 @@
 
           let(:columns) do
             {
-              'tranid' => invoice.id,
+              'tranid' => invoice.number,
               'entity' => integration_customer.external_customer_id,
               'taxregoverride' => true,
               'taxdetailsoverride' => true,
-              'otherrefnum' => invoice.number,
               'custbody_lago_id' => invoice.id,
               'custbody_ava_disable_tax_calculation' => true,
               'custbody_lago_invoice_link' => invoice_link,
@@ -348,11 +346,10 @@
 
           let(:columns) do
             {
-              'tranid' => invoice.id,
+              'tranid' => invoice.number,
               'entity' => integration_customer.external_customer_id,
               'taxregoverride' => true,
               'taxdetailsoverride' => true,
-              'otherrefnum' => invoice.number,
               'custbody_lago_id' => invoice.id,
               'custbody_ava_disable_tax_calculation' => true,
               'custbody_lago_invoice_link' => invoice_link,
@@ -371,11 +368,10 @@
     context 'when tax item is not mapped' do
       let(:columns) do
         {
-          'tranid' => invoice.id,
+          'tranid' => invoice.number,
           'entity' => integration_customer.external_customer_id,
           'taxregoverride' => true,
           'taxdetailsoverride' => true,
-          'otherrefnum' => invoice.number,
           'custbody_lago_id' => invoice.id,
           'custbody_ava_disable_tax_calculation' => true,
           'custbody_lago_invoice_link' => invoice_link,

diff --git a/spec/services/integrations/aggregator/sales_orders/create_service_spec.rb b/spec/services/integrations/aggregator/sales_orders/create_service_spec.rb
@@ -136,11 +136,10 @@
       'type' => 'salesorder',
       'isDynamic' => true,
       'columns' => {
-        'tranid' => invoice.id,
+        'tranid' => invoice.number,
         'taxregoverride' => true,
         'taxdetailsoverride' => true,
         'entity' => integration_customer.external_customer_id,
-        'otherrefnum' => invoice.number,
         'custbody_lago_id' => invoice.id,
         'custbody_ava_disable_tax_calculation' => true,
         'custbody_lago_invoice_link' => invoice_url,