fix(invoice): Add missing unique index on invoice organization_sequen…

…tial ids

app/models/invoice.rb

@@ -279,7 +279,10 @@ def ensure_organization_sequential_id
   end
 
   def generate_organization_sequential_id
-    organization_sequence_scope = organization.invoices.where(created_at: Time.now.utc.all_month)
+    organization_sequence_scope = organization.invoices.where(
+      "date_trunc('month', created_at)::date = ?",
+      Time.now.utc.beginning_of_month.to_date,
+    )
 
     result = Invoice.with_advisory_lock(
       organization_id,

db/migrate/20231214133638_add_unique_index_on_invoice_organization_sequential_id.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+class AddUniqueIndexOnInvoiceOrganizationSequentialId < ActiveRecord::Migration[7.0]
+  disable_ddl_transaction!
+
+  def change
+    add_index :invoices,
+              "organization_id, organization_sequential_id, date_trunc('month'::text, created_at)",
+              name: 'unique_organization_sequential_id',
+              unique: true
+  end
+end

spec/factories/invoices.rb

@@ -10,6 +10,8 @@
     payment_status { 'pending' }
     currency { 'EUR' }
 
+    organization_sequential_id { rand(1_000_000) }
+
     trait :draft do
       status { :draft }
     end

spec/models/invoice_spec.rb

@@ -11,7 +11,7 @@
 
   describe 'sequential_id' do
     let(:customer) { create(:customer, organization:) }
-    let(:invoice) { build(:invoice, customer:, organization:) }
+    let(:invoice) { build(:invoice, customer:, organization:, organization_sequential_id: nil) }
 
     it 'assigns a sequential id and organization sequential id to a new invoice' do
       invoice.save
@@ -98,7 +98,7 @@
     let(:organization) { create(:organization, name: 'LAGO') }
     let(:customer) { create(:customer, organization:) }
     let(:subscription) { create(:subscription, organization:, customer:) }
-    let(:invoice) { build(:invoice, customer:, organization:) }
+    let(:invoice) { build(:invoice, customer:, organization:, organization_sequential_id: nil) }
 
     it 'generates the invoice number' do
       invoice.save