Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagsInput: show radio/checkbox in dropdown #6698

Merged
merged 1 commit into from
Sep 24, 2024
Merged

TagsInput: show radio/checkbox in dropdown #6698

merged 1 commit into from
Sep 24, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Sep 23, 2024 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • Shows the checkboxes/radio buttons in tags input dropdown
Screenshot 2024-09-23 at 6 37 36 PM Screenshot 2024-09-23 at 6 37 41 PM

Reasoning

Inspired by #6672 making the selection more explicit.

Changelog

Enhancements

  • Tags input: dropdown shows current selection via checkbox/radio button

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative requested a review from a team September 23, 2024 16:38
@distantnative distantnative self-assigned this Sep 23, 2024
@distantnative distantnative added this to the 4.5.0 milestone Sep 23, 2024
@distantnative distantnative marked this pull request as ready for review September 23, 2024 16:38
bastianallgeier
bastianallgeier approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I especially like that the checkbox vs. radio button distinction will also help to understand the single vs. multiple tags selection better.

@bastianallgeier bastianallgeier merged commit 7461b11 into develop-minor Sep 24, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the enhancement/tags-input-show-input branch September 24, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier