Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageCreateDialog: prevent tmp using actual page #6643

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 27, 2024

Description

@afbora Would appreciate your testing skills for this.

Summary of changes

  • Page create dialog's temporary page object would use actual page if called new
  • Not a perfect solution (ideal will be real in-memory virtual pages), but a lot less likely for a real-world page __new__

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Aug 27, 2024
@distantnative distantnative added this to the 4.5.0 milestone Aug 27, 2024
@distantnative distantnative self-assigned this Aug 27, 2024
afbora
afbora previously approved these changes Aug 28, 2024
Copy link
Member

@afbora afbora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what risks there might be in cloning an existing page rather than creating a new tmp page, but the issue fixed and everything seems to work fine.

LGTM 👍

@distantnative
Copy link
Member Author

@afbora as @ovenum reports that the new page actually gets created but Kirby itself, this isn't ready as we probably haven't fully caught the bug.

@distantnative distantnative removed this from the 4.5.0 milestone Sep 20, 2024
@distantnative distantnative deleted the fix/6640-page-create-dialog-page-model branch September 20, 2024 14:18
@distantnative distantnative restored the fix/6640-page-create-dialog-page-model branch September 20, 2024 14:25
@distantnative distantnative reopened this Sep 20, 2024
@distantnative distantnative added this to the 4.5.0 milestone Sep 20, 2024
@distantnative distantnative force-pushed the fix/6640-page-create-dialog-page-model branch from efbc830 to e078242 Compare September 20, 2024 14:30
@distantnative distantnative marked this pull request as ready for review September 20, 2024 14:36
@distantnative distantnative merged commit db506f5 into develop-minor Sep 20, 2024
14 checks passed
@distantnative distantnative deleted the fix/6640-page-create-dialog-page-model branch September 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants