Chore: migrate dashboard-icons

[lammersbjorn]

Info: homarr-labs/dashboard-icons#797 (comment).

Note: The walkxcode/dashboard-icons repository will continue to function indefinitely but may no longer receive updates.

[shamoon]

walkxcode himself, cool.

Well thanks for taking the time to PR, thanks for your project.

I think this contains an error at the moment, it's re-declaring the const and the (unintentionally?) added webp block is unreachable

[lammersbjorn]

walkxcode himself, cool.

Well thanks for taking the time to PR, thanks for your project.

I think this contains an error at the moment, it's re-declaring the const and the (unintentionally?) added webp block is unreachable

The constant uses the same logic as the SVG and PNG retrieval. Folder links to jsDelivr show as unreachable because we’ve exceeded the ‘package’ limit. However, direct file links, such as https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/webp/1password.webp, will still work.

[lammersbjorn]

Ah seems like we're missing the if (icon.endsWith(".webp")) {!

[lammersbjorn]

Ideally the PNGs should be removed completely as they have the same function as the WebPs but with a bigger size, but that's all up to you ofcourse. Let me know if you want the WebPs or PNGs :)

[shamoon]

Thanks. Yea we can make the fallback to webp, its support is pretty darn good at this point

[shamoon]

Actually I take that back. That would be breaking or at least kinda confusing. You can add webp if you like but please leave the png for now

[shamoon]

Thanks again

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.