Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: truncate long process names in Glances widget #3079

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix: truncate long process names in Glances widget #3079

merged 1 commit into from
Mar 7, 2024

Conversation

sgrtye
Copy link
Contributor

@sgrtye sgrtye commented Mar 7, 2024

Proposed change

Currently when using the Glances process widget, the process name could overflow given the text is too long, especially on smaller laptops. The screenshot was taken on a 13-inch MacBook in the fullscreen with a reasonable layout standard.
WX20240307-145510@2x

By adding truncate to CSS, it prevents overflow with the maximum information provided. Although there is still a misalignment issue, it is caused by grow and can not be fixed with CSS only.
20240307145831

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon enabled auto-merge (squash) March 7, 2024 15:20
@shamoon shamoon changed the title Fix Glances process name overflow problem Fix: truncate long process names in Glances widget Mar 7, 2024
@shamoon shamoon merged commit 9fdf217 into gethomepage:main Mar 7, 2024
2 checks passed
denispapec pushed a commit to denispapec/homepage that referenced this pull request Mar 17, 2024
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants