[WIP] feat: add php language support #53

ayewo · 2024-03-22T11:36:31Z

WIP PR intended to close #48.

Based on the guidance for adding a new target language in CONTRIBUTING, the following easy tasks have been completed:

0. Add the language as a supported language in the GritQL grammar, like this.
- Already done in 2f458be.
1. Find a tree sitter grammar for the language and add it as a submodule under resources/language-submodules.
2. Add a simple parse test in crates/core/src/test.rs to ensure that the grammar is working.
3. Copy the grammar file into resources/metavariable-grammars. This alternative grammar is used for parsing snippets in GritQL.
4. Patch the metavariable grammar to include $.grit_metavariable anywhere we want to substitute a metavariable. This is usually at least $identifier and $literal.
- For a snippet to match, it also needs to be a field. Often you’ll want to wrap $thing like: field('thing', choice($.grit_metavariable, $thing))
5. Add a new language implementation in crates/core/src/languages. This involves implementing the Language trait and adding a new Language enum variant.
6. Add snippet_context_strings like this to provide context for snippets to match in.
7. Add test cases for the language in crates/core/src/test.rs. This is a good time to add a few dozen test cases to ensure that the language is parsed correctly, and that the metavariable grammar is working.

/claim #48

Summary by CodeRabbit

New Features
- Introduced PHP language support, enhancing the app's ability to parse and understand PHP code with comprehensive coverage of PHP syntax elements.

coderabbitai · 2024-03-22T11:36:39Z

Walkthrough

The update introduces PHP language support to the codebase, enhancing the language support by adding a submodule for tree-sitter-php and defining a comprehensive grammar for PHP code parsing. This expansion includes new test functions, modules for PHP-specific features, and updates to language configurations to accommodate PHP as a supported language.

Changes

File(s)	Change Summary
`.gitmodules`, `.../tree-sitter-php`, `.../node_modules`	Added submodule declaration and PHP language support files.
`.../php-metavariable-grammar.js`	Defined PHP code parsing grammar.
`.../test.rs`	Added test function for parsing a PHP console method.
`.../php_html.rs`, `.../php_only.rs`	Added modules for PHP-specific features.
`.../target_language.rs`	Updated to include PHP-specific enums and configurations.
`.../edit_grammars.mjs`	Updated to include PHP language support logic.

Assessment against linked issues

Objective	Addressed	Explanation
PHP language support (#48)	✅
Working grammar + language support (#48)	✅
At least 10 test cases, including rewrites and metavariables (#48)	❓	The PR description does not explicitly mention the inclusion of at least 10 test cases.

Poem

🐰 In the realm of code, a dance of PHP's song,
tree-sitter weaves, where syntax belongs.
Modules and tests, for PHP's embrace,
Our codebase expands, with skill and grace.
🌟 PHP's journey unfolds, in patterns anew,
With language support strong and true.
Let's celebrate this coding spree,
For PHP's place in our codebase, now we see! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c8f9160 and 824b754.

Files selected for processing (3)

.gitmodules (1 hunks)
resources/language-submodules/tree-sitter-php (1 hunks)
resources/metavariable-grammars/php-metavariable-grammar.js (1 hunks)

Files skipped from review due to trivial changes (1)

resources/language-submodules/tree-sitter-php

Additional comments: 1

.gitmodules (1)

65-67: The addition of the tree-sitter-php submodule is correctly formatted and consistent with the other submodule declarations in the .gitmodules file. This change effectively integrates the PHP grammar into the project, aligning with the PR's objectives to add PHP language support.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 824b754 and 75f7132.

Files ignored due to path filters (1)

vendor/tree-sitter-gritql is excluded by: !**/vendor/**

Files selected for processing (2)

crates/core/src/test.rs (1 hunks)
resources/language-submodules/tree-sitter-php (1 hunks)

Files skipped from review as they are similar to previous changes (1)

resources/language-submodules/tree-sitter-php

Additional comments: 1

crates/core/src/test.rs (1)

12729-12745: The test function parses_php_console_method is well-structured and follows Rust's conventions for unit tests. It's important to ensure that utility methods like trim_margin used in the test are robust and do not introduce panics or unexpected behavior, especially in test scenarios.

…d-php-language

coderabbitai

Review Status

Actionable comments generated: 19

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 75f7132 and 1e9a371.

Files ignored due to path filters (34)

Cargo.lock is excluded by: !**/*.lock
crates/language/Cargo.toml is excluded by: !**/*.toml
resources/language-metavariables/tree-sitter-php/Cargo.lock is excluded by: !**/*.lock
resources/language-metavariables/tree-sitter-php/Cargo.toml is excluded by: !**/*.toml
resources/language-metavariables/tree-sitter-php/build/Release/obj.target/tree_sitter_php_binding/bindings/node/binding.o is excluded by: !**/*.o
resources/language-metavariables/tree-sitter-php/build/Release/obj.target/tree_sitter_php_binding/php/src/parser.o is excluded by: !**/*.o
resources/language-metavariables/tree-sitter-php/build/Release/obj.target/tree_sitter_php_binding/php/src/scanner.o is excluded by: !**/*.o
resources/language-metavariables/tree-sitter-php/build/Release/obj.target/tree_sitter_php_binding/php_only/src/parser.o is excluded by: !**/*.o
resources/language-metavariables/tree-sitter-php/build/Release/obj.target/tree_sitter_php_binding/php_only/src/scanner.o is excluded by: !**/*.o
resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.js.map is excluded by: !**/*.map
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.mjs.map is excluded by: !**/*.map
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/index.js.map is excluded by: !**/*.map
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/index.mjs.map is excluded by: !**/*.map
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/dist/eslintrc-universal.cjs.map is excluded by: !**/*.map
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/dist/eslintrc.cjs.map is excluded by: !**/*.map
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/js/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@humanwhocodes/config-array/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@humanwhocodes/module-importer/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@humanwhocodes/object-schema/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@isaacs/cliui/node_modules/ansi-regex/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@isaacs/cliui/node_modules/strip-ansi/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@isaacs/cliui/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@nodelib/fs.scandir/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@nodelib/fs.stat/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@nodelib/fs.walk/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@npmcli/agent/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@npmcli/fs/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@pkgjs/parseargs/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@ungap/structured-clone/cjs/package.json is excluded by: !**/*.json
resources/language-metavariables/tree-sitter-php/node_modules/@ungap/structured-clone/package.json is excluded by: !**/*.json

Files selected for processing (82)

crates/core/src/test.rs (1 hunks)
crates/language/src/lib.rs (1 hunks)
crates/language/src/php_html.rs (1 hunks)
crates/language/src/php_only.rs (1 hunks)
crates/language/src/target_language.rs (17 hunks)
resources/edit_grammars.mjs (4 hunks)
resources/language-metavariables/tree-sitter-php/.eslintrc.js (1 hunks)
resources/language-metavariables/tree-sitter-php/.npmignore (1 hunks)
resources/language-metavariables/tree-sitter-php/LICENSE (1 hunks)
resources/language-metavariables/tree-sitter-php/Makefile (1 hunks)
resources/language-metavariables/tree-sitter-php/Package.swift (1 hunks)
resources/language-metavariables/tree-sitter-php/README.md (1 hunks)
resources/language-metavariables/tree-sitter-php/binding.gyp (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/c/tree-sitter.h.in (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/c/tree-sitter.pc.in (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/node/binding.cc (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/node/index.js (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/node/php.js (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/node/php_only.js (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/rust/README.md (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/rust/build.rs (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/rust/lib.rs (1 hunks)
resources/language-metavariables/tree-sitter-php/bindings/swift/TreeSitterPHP/php.h (1 hunks)
resources/language-metavariables/tree-sitter-php/build/Makefile (1 hunks)
resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/bindings/node/binding.o.d (1 hunks)
resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php/src/parser.o.d (1 hunks)
resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php/src/scanner.o.d (1 hunks)
resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php_only/src/parser.o.d (1 hunks)
resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php_only/src/scanner.o.d (1 hunks)
resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/tree_sitter_php_binding.node.d (1 hunks)
resources/language-metavariables/tree-sitter-php/build/binding.Makefile (1 hunks)
resources/language-metavariables/tree-sitter-php/build/config.gypi (1 hunks)
resources/language-metavariables/tree-sitter-php/build/gyp-mac-tool (1 hunks)
resources/language-metavariables/tree-sitter-php/build/tree_sitter_php_binding.target.mk (1 hunks)
resources/language-metavariables/tree-sitter-php/common/define-grammar.js (1 hunks)
resources/language-metavariables/tree-sitter-php/common/scanner.h (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/bugs.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/class.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/declarations.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/execution_operator.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/expressions.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/literals.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/statements.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/string.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/corpus/types.txt (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/highlight/keywords.php (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/highlight/literals.php (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/highlight/types.php (1 hunks)
resources/language-metavariables/tree-sitter-php/common/test/highlight/variables.php (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/acorn (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/eslint (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/glob (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/js-yaml (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/mkdirp (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/node-gyp (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/node-which (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/nopt (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/prebuild-install (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/rc (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/resolve (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/rimraf (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/semver (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/shjs (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.bin/tree-sitter (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/.yarn-integrity (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/LICENSE (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/README.md (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/index.d.ts (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/index.js (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/LICENSE (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/README.md (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.js (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.mjs (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/node_modules/.bin/eslint (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/LICENSE (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/README.md (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/index.d.ts (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/LICENSE (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/README.md (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/conf/config-schema.js (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/conf/environments.js (1 hunks)
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/dist/eslintrc-universal.cjs (1 hunks)

Files not summarized due to errors (3)

resources/language-metavariables/tree-sitter-php/node_modules/.yarn-integrity: Error: Message exceeds token limit
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.js: Error: Message exceeds token limit
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.mjs: Error: Message exceeds token limit

Files skipped from review due to trivial changes (23)

crates/language/src/lib.rs
resources/language-metavariables/tree-sitter-php/.npmignore
resources/language-metavariables/tree-sitter-php/LICENSE
resources/language-metavariables/tree-sitter-php/bindings/node/php.js
resources/language-metavariables/tree-sitter-php/bindings/node/php_only.js
resources/language-metavariables/tree-sitter-php/build/binding.Makefile
resources/language-metavariables/tree-sitter-php/build/config.gypi
resources/language-metavariables/tree-sitter-php/node_modules/.bin/acorn
resources/language-metavariables/tree-sitter-php/node_modules/.bin/eslint
resources/language-metavariables/tree-sitter-php/node_modules/.bin/js-yaml
resources/language-metavariables/tree-sitter-php/node_modules/.bin/node-gyp
resources/language-metavariables/tree-sitter-php/node_modules/.bin/node-which
resources/language-metavariables/tree-sitter-php/node_modules/.bin/prebuild-install
resources/language-metavariables/tree-sitter-php/node_modules/.bin/resolve
resources/language-metavariables/tree-sitter-php/node_modules/.bin/rimraf
resources/language-metavariables/tree-sitter-php/node_modules/.bin/semver
resources/language-metavariables/tree-sitter-php/node_modules/.bin/shjs
resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/LICENSE
resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/README.md
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/LICENSE
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/node_modules/.bin/eslint
resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/LICENSE
resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/LICENSE

Files skipped from review as they are similar to previous changes (1)

crates/core/src/test.rs

Additional comments: 137

resources/language-metavariables/tree-sitter-php/bindings/swift/TreeSitterPHP/php.h (1)

1-17: The header file is well-structured, correctly uses include guards, and properly declares functions for obtaining TSLanguage instances for PHP. This aligns with C/C++ best practices for header files.

resources/language-metavariables/tree-sitter-php/bindings/c/tree-sitter.h.in (1)

1-16: The template file is well-structured and correctly uses include guards and extern "C" for C++ compatibility. Ensure that the processing step that replaces @UPPER_PARSERNAME@ and @PARSERNAME@ placeholders with language-specific details is correctly implemented.

resources/language-metavariables/tree-sitter-php/bindings/c/tree-sitter.pc.in (1)

1-11: The pkg-config file template is correctly structured with placeholders for configuration and language-specific details. Ensure that the processing step that replaces placeholders like @PREFIX@, @LIBDIR@, @INCLUDEDIR@, @ADDITIONALLIBS@, @PARSERNAME@, @PARSERURL@, and @VERSION@ is correctly implemented.

resources/language-metavariables/tree-sitter-php/common/test/highlight/literals.php (1)

1-19: The PHP test file for syntax highlighting is well-structured and includes a variety of syntax elements for comprehensive testing. The comments indicating expected highlighting categories are clear and appropriate.

resources/language-metavariables/tree-sitter-php/.eslintrc.js (1)

1-20: The ESLint configuration file is appropriately set up, extending the Google style guide and defining sensible rules for code quality and style. Ensure that this configuration aligns with the project's coding standards and preferences.

resources/language-metavariables/tree-sitter-php/binding.gyp (1)

1-21: The GYP configuration file for the Node.js bindings is correctly set up, specifying include directories, sources, and appropriate C flags for compatibility with the C99 standard. Ensure that the paths to include directories and source files are correct and compatible with the project's build system.

resources/language-metavariables/tree-sitter-php/common/test/highlight/variables.php (1)

1-21: The syntax highlighting annotations for PHP variables, constructors, and built-in variables are correctly implemented.

resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/tree_sitter_php_binding.node.d (1)

1-1: The build command for tree_sitter_php_binding.node follows standard practices for compiling node modules on macOS.
resources/language-metavariables/tree-sitter-php/bindings/node/index.js (1)
1-20: The error handling and fallback mechanism for requiring the tree_sitter_php_binding module are correctly implemented. Ensure that the paths to the node-types.json files are correct and that these files exist.

Verification successful

The executed script successfully listed the node-types.json files, including the ones for php and php_only as specified in the code snippet:

resources/language-metavariables/tree-sitter-php/php/src/node-types.json

resources/language-metavariables/tree-sitter-php/php_only/src/node-types.json

This confirms that the paths to the node-types.json files are correct and that these files indeed exist in the repository as required by the code under review.
Scripts Executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Verify the existence of node-types.json files for php and php_only.
fd --type f --name "node-types.json" --exec test -f {} \; || echo "Missing node-types.json file"
Length of output: 378

Script:
#!/bin/bash
# Correctly verify the existence of node-types.json files for php and php_only.
fd "node-types.json" --exec test -f {} \; || echo "Missing node-types.json file"
Length of output: 1875

Script:
#!/bin/bash
# List node-types.json files to verify their existence directly.
fd "node-types.json"
Length of output: 3010
resources/language-metavariables/tree-sitter-php/common/test/highlight/types.php (1)

1-21: The syntax highlighting annotations for PHP types, both built-in and custom, are correctly implemented.

resources/language-metavariables/tree-sitter-php/node_modules/.bin/nopt (1)

1-1: The script correctly implements command-line argument parsing using the nopt package.

resources/language-metavariables/tree-sitter-php/Package.swift (1)

1-29: The Swift package definition for TreeSitterPHP follows Swift Package Manager conventions and correctly specifies the necessary settings for compiling the C sources.

resources/language-metavariables/tree-sitter-php/README.md (1)

1-15: The README provides a clear overview of the tree-sitter-php project. The content is well-structured and adheres to markdown best practices.

resources/language-metavariables/tree-sitter-php/bindings/rust/build.rs (1)

1-29: The build script for the tree-sitter-php project is correctly configured and follows best practices for Rust project build scripts. It properly sets up the include paths, compiler flags, and rerun-if-changed instructions.

resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php/src/parser.o.d (1)

1-1: Ensure that the paths specified in the compilation command are correct and accessible in the build environment. This includes paths to node-gyp caches, node modules, and PHP source files. Also, verify that the compilation flags are appropriate for the target environment.

resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/index.d.ts (2)

6-6: The function wrap is correctly typed to accept a string and an optional IOptions object, returning a string. This aligns with TypeScript best practices for defining module exports and function signatures.

8-48: The IOptions interface is well-defined, with appropriate types and default values documented in comments. This provides clear guidance for users of the wrap function on how to customize its behavior.

resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php_only/src/parser.o.d (1)

1-1: As with the previous dependency file, ensure that the specified paths and compilation flags are correct and suitable for the build environment. This is crucial for successful compilation and integration of the php_only parser component.

resources/language-metavariables/tree-sitter-php/node_modules/@aashutoshrathi/word-wrap/index.js (2)

8-12: The trimTabAndSpaces function correctly trims trailing spaces from each line. This utility function enhances the output of the main word-wrap functionality by ensuring clean line endings.

14-47: The main word-wrap function is implemented with clear logic and sensible defaults. It handles various options to customize the wrapping behavior, including width, indent, newline, escape, and trim options. Ensure that the function is thoroughly tested, especially with edge cases such as very long words and different combinations of options.

resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php/src/scanner.o.d (1)

1-1: Ensure the compilation command for the scanner object file includes correct paths and flags, similar to the parser object files. This consistency is important for the successful integration of the scanner component.

resources/language-metavariables/tree-sitter-php/build/Release/.deps/Release/obj.target/tree_sitter_php_binding/php_only/src/scanner.o.d (1)

1-1: As with the other dependency files, verify that the paths and flags in the compilation command for the php_only scanner object are correct and appropriate for the build environment.

resources/language-metavariables/tree-sitter-php/bindings/node/binding.cc (1)

1-37: The Node.js bindings for the PHP and PHP-only grammars are correctly defined and exported. Ensure that the grammars (tree_sitter_php and tree_sitter_php_only) are correctly implemented and that the bindings are tested in a Node.js environment.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/README.md (1)

10-10: Ensure that the description "for make ESLint custom rules" is grammatically correct. It might be clearer as "for making ESLint custom rules."
resources/language-metavariables/tree-sitter-php/node_modules/.bin/mkdirp (1)
1-1: Ensure that the relative path used in the script is correct and accessible from the script's location.

Verification successful

The verification process confirmed the existence of cmd.js within the mkdirp/bin directory, as expected. This supports the correctness of the relative path used in the script, assuming it is intended to interact with or reference cmd.js.
Scripts Executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Verify the relative path to `mkdirp/bin/cmd.js`
fd 'cmd.js' --exec test -f {}
Length of output: 67

Script:
#!/bin/bash
# Verify the existence of `cmd.js` within the `mkdirp/bin` directory by listing it
fd 'cmd.js'
Length of output: 91
resources/language-metavariables/tree-sitter-php/common/test/corpus/literals.txt (1)

5-115: Ensure that all PHP literals are covered in the test corpus, including edge cases for each type (Booleans, Floats, Integers, Strings, Shell commands).

resources/language-metavariables/tree-sitter-php/bindings/rust/lib.rs (1)

28-28: Consider documenting the language_php function to explain its purpose and usage within the context of the bindings.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/conf/config-schema.js (1)

25-25: The ecmaFeatures property is marked as deprecated. Ensure that this deprecation is clearly documented and that alternatives are provided for users.

crates/language/src/php_html.rs (1)

29-29: Ensure that the lang parameter is properly documented, including its purpose and the conditions under which it should be provided.

crates/language/src/php_only.rs (1)

29-29: Ensure that the lang parameter is properly documented, including its purpose and the conditions under which it should be provided, similar to the php_html.rs file for consistency.

resources/language-metavariables/tree-sitter-php/common/test/highlight/keywords.php (1)

1-153: Ensure that all PHP keywords are covered in the test file and that the annotations for highlighting are correctly applied.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/README.md (1)

1-115: The README provides a comprehensive overview of the ESLintRC Library, including installation and usage instructions. It's well-structured and informative. However, ensure that the library version and Node.js version requirements are up-to-date with the latest standards and compatible with the project's environment.

resources/language-metavariables/tree-sitter-php/Makefile (1)

1-113: The Makefile is well-structured and follows standard conventions for defining build rules and variables. However, consider parameterizing the version (VERSION := 0.19.0) and paths to make the Makefile more flexible and easier to maintain. Also, ensure that the compiler flags are optimized for both development (Debug) and production (Release) builds.

resources/language-metavariables/tree-sitter-php/common/test/corpus/execution_operator.txt (1)

1-176: The test cases for the execution operator are comprehensive and cover a wide range of scenarios, including quotes, escape sequences, and variable interpolation. Ensure that these tests are executed as part of the continuous integration process to maintain the quality of the parser. Additionally, consider adding more edge cases if any are known to further improve the robustness of the parser.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/conf/environments.js (1)

1-215: The environment configurations in environments.js are correctly defined and align with the ECMAScript standards. It's important to keep this file updated with the latest ECMAScript versions and their respective global variables to ensure accurate linting. Additionally, consider adding comments to describe the purpose of each environment configuration for better maintainability.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/regexpp/README.md (1)

1-177: The README for @eslint-community/regexpp is clear and informative, providing all necessary details for installation, usage, and contribution. Ensure that the package version and Node.js version requirements are up-to-date. Additionally, consider adding a section on common use cases or examples where this package can be particularly useful to provide more context to potential users.

resources/language-metavariables/tree-sitter-php/build/tree_sitter_php_binding.target.mk (1)

1-205: This generated Makefile for tree_sitter_php_binding is correctly structured and includes all necessary build configurations for Debug and Release modes. Ensure that the paths and version numbers are dynamically generated to reflect the actual environment and dependencies. Additionally, review the compiler and linker flags to ensure they are optimized for performance and compatibility across different platforms.

resources/language-metavariables/tree-sitter-php/common/test/corpus/bugs.txt (1)

1-233: The test cases in bugs.txt effectively cover a range of reported issues, ensuring that the parser handles these scenarios correctly. It's crucial to continuously update this file with new test cases as bugs are reported and fixed to prevent regressions. Consider adding comments to each test case to provide context about the bug it addresses and the expected behavior.

resources/language-metavariables/tree-sitter-php/node_modules/.bin/glob (4)

1-1: Using dynamic imports with await outside of an async function or top-level await context (if supported in your environment) can lead to syntax errors or unexpected behavior. Ensure that your runtime environment supports top-level await.

Please verify that your project's runtime environment supports top-level await, as it's used in the dynamic import and readFile operation for fetching the package version.

1-1: The script uses existsSync and readFile from the fs module without any apparent error handling for file access or read operations. This could lead to unhandled exceptions if the file does not exist or if there are permissions issues.

Consider adding error handling for file operations to gracefully handle cases where files cannot be accessed or read, improving the robustness of the script.

1-1: The extensive use of command-line flags and options adds complexity to the script. While this provides flexibility, it also increases the risk of errors and makes the code harder to maintain.

Consider simplifying the command-line interface or providing detailed documentation to help users understand the available options and their effects. This can improve usability and maintainability.

1-1: The script lacks comments explaining the purpose and functionality of significant blocks of code, which can make it difficult for other developers to understand and maintain the code.

Consider adding comments to explain the purpose and functionality of significant blocks of code, especially for complex logic or less obvious implementations. This can improve code readability and maintainability.

resources/edit_grammars.mjs (1)

302-305: The wasm build steps for PHP are commented out. If this is temporary or under development, consider adding a TODO comment for clarity and future action.

Also applies to: 310-311

resources/language-metavariables/tree-sitter-php/build/Makefile (3)

7-7: Consider adding a comment explaining the purpose of setting MAKEFLAGS=-r for future maintainability. While it's mentioned that it saves time by avoiding implicit rules, a bit more context could be helpful.

82-119: The dependency file generation and fixup process is complex and involves several steps, including handling spaces and missing files. Consider adding more detailed comments or breaking down the fixup_dep definition for clarity and maintainability.

241-254: The do_cmd definition is crucial for the build process, handling command execution and dependency munging. Ensure that the logic here is thoroughly tested, especially the conditions for command execution and dependency fixup. Consider adding unit tests for this part of the Makefile if not already present.

resources/language-metavariables/tree-sitter-php/common/test/corpus/declarations.txt (10)

1-45: Ensure that the test cases for interface and class declarations are comprehensive and cover all relevant PHP syntax variations. It might be beneficial to add more complex examples, including methods with different visibility, static methods, and methods with default parameter values.

46-87: The use declarations section tests trait usage within classes and traits. Consider adding tests for conflict resolution with the insteadof operator and method visibility change with the as operator to ensure comprehensive coverage of trait functionalities.

88-112: Namespace names in namespaces are tested, but the examples are quite basic. To enhance test coverage, consider adding more complex namespace scenarios, such as nested namespaces, using namespaces, and aliasing.

113-164: The class declarations section tests constructors and methods accessing global variables. It's recommended to include tests for class properties (public, protected, private), constants, and static properties/methods to ensure the grammar correctly handles these elements.

183-206: Function parameters are tested, but the examples do not cover all possible types and default values. Adding tests for nullable types, array types, and default values for scalar types would provide a more thorough validation of the grammar's capability to parse function parameters.

207-227: Functions with default parameters are tested, but only one case is shown. Expanding this section with more examples, including default values for different types (e.g., arrays, nullables) and using constants as default values, would improve test coverage.

228-249: Static variables in functions are covered, but only with integer types. Consider adding more tests with different types of static variables, including arrays, strings, and objects, to ensure the grammar can handle various static variable declarations.

250-319: The section on defining constants tests various ways to define constants in PHP. To enhance the test coverage, consider adding more complex scenarios, such as class constants, magic constants, and constants defined in namespaces.

321-636: Attributes are a relatively new feature in PHP. The tests cover a good range of use cases, but consider adding more complex attribute scenarios, such as repeating attributes, attributes on different PHP elements (e.g., properties, classes, functions), and attributes with complex arguments.

638-730: Enums are a new feature in PHP 8.1. The tests cover basic enum declarations and cases. To ensure comprehensive coverage, consider adding tests for enums with methods, backing types other than int and string, and enums used in type hints.

resources/language-metavariables/tree-sitter-php/common/test/corpus/class.txt (1)

1-824: The test cases provided cover a wide range of PHP class syntax features, including abstract classes, anonymous classes, conditional class definitions, class constant modifiers, typed class constants, final classes, implicitly public properties and methods, property types, constructor property promotion, readonly properties, and constructor property promotion with readonly modifier. These are essential for ensuring the PHP parser's accuracy and robustness in handling different class-related syntaxes.

However, it's important to verify that these test cases align with the latest PHP syntax rules and that they are comprehensive enough to cover edge cases and common usage patterns. Adding comments to explain complex or non-obvious test cases can also improve maintainability and understandability of the test suite.

resources/language-metavariables/tree-sitter-php/common/scanner.h (5)

11-16: The VEC_RESIZE macro uses realloc for resizing vectors and asserts that the reallocation was successful. While this is generally acceptable, it's important to consider the behavior in low-memory situations. In production code, it might be preferable to handle memory allocation failures more gracefully than terminating the program. Consider adding error handling to allow the caller to respond to allocation failures.

91-100: The string_eq function compares two strings for equality. It's efficient and correctly handles the comparison. However, it's worth noting that this function assumes both strings are well-formed and their len fields accurately reflect their lengths. Ensure that all strings manipulated by this function are correctly initialized and maintained to prevent incorrect comparisons.

197-198: The is_valid_name_char function checks if a character is valid within a PHP name, allowing alphanumeric characters, underscores, and characters with codes above 128. This is consistent with PHP's naming rules. However, ensure this function is used in contexts where PHP's naming conventions apply, as it might not be suitable for parsing other parts of the PHP syntax that have different character requirements.

201-227: The is_escapable_sequence function checks for escapable sequences in strings. It's crucial that this function stays up-to-date with PHP's escape sequence rules. Given the complexity of escape sequences (including hex, unicode, and octal), it's recommended to periodically review this function against the latest PHP documentation to ensure all valid escape sequences are correctly identified.

291-425: The scan_encapsed_part_string function handles scanning parts of encapsed strings, including handling after variable contexts, heredoc syntax, and execution strings. This function is complex due to the various contexts it needs to handle. It's well-structured, but given the complexity, it's important to ensure comprehensive test coverage for this function to catch edge cases and ensure it behaves correctly in all supported PHP syntax scenarios.

resources/language-metavariables/tree-sitter-php/common/test/corpus/string.txt (11)

7-7: The test case correctly demonstrates variable interpolation within a string in PHP. This is a standard feature of PHP where variables can be embedded directly within double-quoted strings.

23-23: This test case is designed to ensure that spaces between { and $ in a string are not allowed for variable interpolation, which aligns with PHP's syntax rules.

40-70: These examples cover a wide range of complex string interpolation scenarios in PHP, including object and array access within strings, function and method calls, and class constant access. It's comprehensive and accurately reflects PHP's capabilities in string interpolation.

195-211: Simple variable access within strings is demonstrated here. Both the $variable syntax and the ${variable} syntax are correctly shown, which are valid in PHP for interpolating variable values within strings.

218-267: This segment tests member and array access within strings, including complex expressions like accessing object properties and array elements. The use of PHP_EOL for line breaks is also correctly demonstrated. These examples are valid and showcase PHP's flexibility in string interpolation.

276-304: Corner cases for string parsing are thoroughly tested here, including handling of special characters, escape sequences, and complex variable interpolation scenarios. This section is crucial for ensuring the robustness of the PHP parser implementation in handling edge cases.

445-479: Single quoted strings in PHP do not support variable interpolation, and this is correctly demonstrated in these test cases. Special characters are also shown to be treated literally within single quoted strings, which aligns with PHP's behavior.

486-499: This test case appears to be related to a specific bug, likely ensuring that certain string patterns do not cause parsing errors or unexpected behavior. It's important to have such targeted tests to prevent regressions.

508-608: Heredoc and Nowdoc syntaxes are extensively tested here, covering various scenarios including variable interpolation in Heredoc and the literal treatment of content in Nowdoc. These tests are essential for verifying the parser's handling of these PHP string syntaxes.

915-948: Testing Heredoc and Nowdoc with numbers in the identifier ensures that the parser correctly handles identifiers that start with an underscore followed by numbers, which is a valid syntax in PHP.

956-972: Unicode escape sequences within strings are tested here. This feature allows for the inclusion of Unicode characters in strings using a specific escape syntax, which is a relatively recent addition to PHP. These tests ensure that the parser correctly interprets these sequences.

crates/language/src/target_language.rs (15)

14-15: Adding PhpHtml and PhpOnly to the imports ensures that the PHP language support is correctly integrated into the project's language handling. This is a necessary step for enabling PHP parsing and analysis.

70-71: The inclusion of PhpHtml and PhpOnly in the PatternLanguage enum is essential for distinguishing between different PHP parsing contexts. This allows for more granular control over PHP code parsing, especially when dealing with PHP embedded in HTML.

98-99: The fmt::Display implementation for PatternLanguage has been updated to handle PhpHtml and PhpOnly. Both are represented as "php" when converted to a string, which is appropriate since they are variations of the PHP language. However, consider if there's a need to distinguish between these variations in any user-facing contexts.

128-129: The conversion from TargetLanguage to PatternLanguage now correctly handles PhpHtml and PhpOnly. This ensures that the internal representations of languages are consistent across different parts of the project.

157-158: The is_initialized method's update to include PhpHtml and PhpOnly ensures that initialization checks can be performed for these new language variants. This is crucial for any setup or configuration steps that need to be done before parsing PHP code.

224-228: The from_string method's handling of "php" with different flavors ("html" and "only") is a smart way to parse language strings into the correct PatternLanguage variants. This allows for flexibility in specifying the PHP parsing context through strings.

258-259: The get_file_extensions method now correctly returns "php" for both PhpHtml and PhpOnly. This aligns with the fact that both variants are essentially PHP code, regardless of the context in which they are used.

286-287: The get_default_extension method's update to include PhpHtml and PhpOnly ensures that "php" is returned as the default file extension for PHP files. This is consistent with standard PHP file naming conventions.

311-311: The from_extension method's handling of "php" to default to PhpOnly is a reasonable default behavior. However, consider if there might be cases where distinguishing between PhpHtml and PhpOnly based on file extension or other criteria could be beneficial.

473-478: The expand_paths function's update to handle PhpHtml and PhpOnly ensures that PHP files are correctly identified and processed during file system traversal. This is important for features like code search and analysis that operate on file collections.

526-527: Adding PhpHtml and PhpOnly to the TargetLanguage enum is crucial for supporting PHP in the project's language-specific functionalities. This allows for PHP code to be processed and analyzed with the appropriate context and settings.

560-561: The TryFrom<PatternLanguage> implementation for TargetLanguage now correctly handles PhpHtml and PhpOnly, ensuring that conversions between pattern and target languages are accurate for PHP variants.

592-593: The fmt::Display implementation for TargetLanguage has been updated to include PhpHtml and PhpOnly, both represented as "php". This consistency in representation is suitable, though it's important to ensure that any necessary distinctions between these variants are made clear in contexts where it matters.

637-638: The to_module_language method's handling of PhpHtml and PhpOnly ensures that these target languages can be correctly converted back to their pattern language counterparts. This is important for operations that require moving between different representations of languages.

664-665: The should_pad_snippet method's update to include PhpHtml and PhpOnly with a return value of false indicates that padding is not required for PHP snippets. This decision should be based on the formatting and presentation requirements specific to PHP code snippets.

resources/language-metavariables/tree-sitter-php/build/gyp-mac-tool (2)

1-1: The use of #!/usr/bin/env python3 as a shebang line is good practice for ensuring compatibility with Python 3.

119-122: Consider adding more robust error handling for subprocess calls. Catching subprocess.CalledProcessError is a good start, but ensure that all potential errors are handled appropriately to prevent unexpected script behavior.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/dist/eslintrc-universal.cjs (4)

38-58: The function getRuleSeverity is well-implemented with clear logic for handling different types of severity inputs. It's a good example of defensive programming, ensuring that the function can handle unexpected input gracefully.

121-141: The normalizeConfigGlobal function correctly handles various inputs for global configuration. The use of a switch statement makes the logic clear and easy to follow. However, consider documenting the expected input values and the rationale behind the normalization for future maintainers.

368-388: The ajvOrig function setup for Ajv is correctly configured with sensible defaults for ESLint's use case. Including comments or documentation on why specific Ajv options were chosen (e.g., meta: false, useDefaults: true) would be beneficial for maintainability.

704-988: The ConfigValidator class is comprehensive, covering various aspects of ESLint configuration validation. It's well-structured and makes good use of helper functions for clarity. Ensure that all new rules or configuration options introduced by ESLint or plugins are accounted for in the validation logic to prevent future issues.

resources/language-metavariables/tree-sitter-php/common/test/corpus/expressions.txt (32)

1-14: The "Dynamic variable names" test case is correctly implemented and demonstrates the expected behavior in PHP.

16-57: The "Exponentiation" test case accurately captures the behavior of the exponentiation operator in PHP, including edge cases like negative exponentiation and augmented assignment.

59-74: The "Reserved Identifiers as Names" test case correctly demonstrates PHP's handling of reserved identifiers in object creation expressions.

76-93: The "Unary op with assignment expressions" test case is well-formed and accurately tests PHP's behavior of combining unary operations with assignment expressions.

95-111: The "Capitalized logical operators" test case correctly demonstrates PHP's support for capitalized logical operators and their expected parse behavior.

113-133: The "Cast expressions in assignments" test case accurately tests PHP's handling of cast expressions within assignment and augmented assignment expressions.

135-155: The "Cast include" test case correctly demonstrates the behavior of casting the result of an include statement to an array in PHP.

157-173: The "Reserved words as function calls" test case accurately demonstrates PHP's handling of reserved words in object creation expressions.

175-191: The "Scoped self call expressions" test case correctly demonstrates the use of self for calling a static method in a scoped context in PHP.

193-338: The "Symmetric array destructuring" test case comprehensively covers PHP's array destructuring syntax, including list-style and square bracket syntax, with nuances like trailing commas and skipping arguments.

341-384: The "Precedence of assignment, or, xor, and and" test case accurately tests the precedence and associativity of these operators in PHP, as reflected in the expected parse tree.

387-404: The "Associativity of conditional" test case correctly tests the right associativity of the ternary conditional operator in PHP.

407-422: The "Associativity of null-coalescence" test case accurately tests the left associativity of the null-coalescence operator in PHP.

425-446: The "Associativity of negation" test case accurately tests the behavior of arithmetic and logical negation operators in PHP.

449-491: The "Augmented assignment" test case correctly tests various augmented assignment expressions in PHP, including string concatenation and addition.

494-511: The "Nested assignments" test case accurately demonstrates nested assignments within array subscript expressions in PHP.

514-598: The "All binary op precedence levels" test case comprehensively tests the precedence levels of all binary operators in PHP, as demonstrated by the expected parse tree.

601-620: The "Concatenation precedence" test case accurately tests the precedence between string concatenation and addition in PHP.

623-658: The "Arrays" test case correctly tests array creation expressions in PHP, including associative arrays and array spreading.

661-722: The "Anonymous functions" test case accurately tests anonymous function expressions in PHP, including variations with use clauses and reference parameters.

726-855: The "Throw expressions" test case comprehensively covers throw expressions in various contexts in PHP, including conditional expressions and binary expressions.

858-909: The "Nullsafe operator" test case accurately tests the nullsafe operator in member access and function call expressions in PHP.

913-973: The "First class callable syntax" test case accurately explores the first-class callable syntax in PHP, including parser-level acceptance of invalid cases.

977-1042: The "Match expressions" test case comprehensively tests the match expression syntax in PHP, including class constant access and default cases.

1046-1136: The "Arrow functions" test case accurately covers various forms of arrow functions in PHP, including static arrow functions, reference parameters, and return types.

1139-1160: The "Functions with named arguments" test case correctly demonstrates the use of named arguments in function calls in PHP.

1163-1181: The "Precedence between concatenation and shift" test case accurately examines the precedence between string concatenation and the shift operator in PHP.

1185-1462: The "References" test case comprehensively covers various aspects of references in PHP, including reference assignments, function parameters, arrow functions, and class methods.

1466-1487: The "Empty match expressions" test case correctly tests the syntax for an empty match expression in PHP.

1490-1504: The "Dynamic class constant access" test case accurately demonstrates dynamic access to class constants in PHP.

1506-1537: The "UTF-8 identifiers" test case accurately tests the use of UTF-8 characters in identifiers and heredoc/nowdoc syntax in PHP.

1540-1560: The "Yield expressions" test case accurately covers various forms of yield expressions in PHP, including bare yield, yield with a value, and yield from.

resources/language-metavariables/tree-sitter-php/common/define-grammar.js (4)

46-49: The dialect check ensures that only 'php' or 'php_only' are accepted as valid dialects. This is a good practice for validating input parameters and preventing unexpected behavior.

51-1578: The grammar definition is comprehensive and covers a wide range of PHP syntax elements. It's well-structured and makes good use of precedence levels and external rules to accurately parse PHP code. However, ensure that all PHP syntax variations, especially newer features, are adequately covered by the grammar rules.

1590-1595: The keyword function simplifies the creation of case-insensitive regex patterns for PHP keywords and optionally aliases them. This is a neat approach to handling PHP's case-insensitive nature for keywords.

1605-1607: The commaSep1 function is a useful utility for defining grammar rules that require one or more repetitions of a pattern separated by commas. It enhances readability and maintainability of the grammar rules.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.mjs (5)

9-28: The implementation of getInnermostScope correctly iterates through child scopes to find the innermost scope containing a given location. This is a fundamental utility for scope analysis in ASTs.

36-55: The findVariable function is well-implemented, providing a robust way to find a variable by name or node within a given scope. It correctly handles different types of inputs and navigates through the scope chain.

82-111: The token checking functions (isArrowToken, isCommaToken, isSemicolonToken, etc.) are correctly implemented, providing a clear and efficient way to check for specific token types and values. This pattern of implementation promotes code reuse and maintainability.

1472-1537: The PatternMatcher class is a well-designed utility for matching patterns in strings with consideration for escape sequences. Its API is clear, and it correctly uses generators for efficient iteration over matches. This class could be very useful for tasks that involve pattern matching in code analysis or transformation.

1587-1974: The ReferenceTracker class provides comprehensive functionality for tracking references to global variables and modules in both CommonJS and ES module formats. Its design allows for flexible tracking configurations and supports a variety of use cases in code analysis. The implementation correctly handles the intricacies of different module systems and reference patterns.

resources/language-metavariables/tree-sitter-php/node_modules/@eslint-community/eslint-utils/index.js (2)

1480-1541: The PatternMatcher class provides a powerful way to find patterns in strings with consideration for escape sequences. However, it's important to ensure that the regular expression used with PatternMatcher is properly sanitized if it's constructed from dynamic inputs to avoid potential Regular Expression Denial of Service (ReDoS) vulnerabilities.

Ensure that any dynamic inputs used to construct regular expressions for PatternMatcher are properly sanitized or validated to avoid ReDoS vulnerabilities.

1590-1973: The ReferenceTracker class is a comprehensive tool for tracking references in code. It's well-structured and provides clear functionality for different types of module systems (CommonJS and ES modules). However, when iterating over references, especially in methods like iterateGlobalReferences, iterateCjsReferences, and iterateEsmReferences, it's crucial to handle potential cyclic references or deep nesting that could lead to performance issues.

Consider implementing depth limits or checks for cyclic references within the ReferenceTracker's iteration methods to prevent potential performance issues in complex codebases.

coderabbitai · 2024-03-25T17:49:08Z

resources/language-metavariables/tree-sitter-php/node_modules/.bin/glob

@@ -0,0 +1 @@
+../glob/dist/esm/bin.mjs


The import statement for ../glob/dist/esm/bin.mjs seems to be misplaced or incorrect as it's not a valid JavaScript import statement. This could potentially cause a syntax error or unexpected behavior.

- ../glob/dist/esm/bin.mjs

Consider removing or correcting this line if it was intended to be a comment or a different kind of directive.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

../glob/dist/esm/bin.mjs

#!/usr/bin/env node

The use of foregroundChild to execute commands with glob pattern matches as arguments could potentially introduce security vulnerabilities if user-supplied input is not properly sanitized. This could lead to command injection attacks.

Ensure that all user inputs are properly sanitized before being passed to foregroundChild to prevent command injection vulnerabilities.

The script mixes concerns by directly handling command-line parsing, glob pattern matching, and command execution within a single file. This could affect modularity and maintainability.

Refactor the script to separate concerns, such as by moving the command-line interface definition, glob pattern matching logic, and command execution into separate modules. This can improve modularity and maintainability.

coderabbitai · 2024-03-25T17:49:08Z

resources/language-metavariables/tree-sitter-php/build/gyp-mac-tool

+    def Dispatch(self, args):
+        """Dispatches a string command to a method."""
+        if len(args) < 1:
+            raise Exception("Not enough arguments")
+
+        method = "Exec%s" % self._CommandifyName(args[0])
+        return getattr(self, method)(*args[1:])
+
+    def _CommandifyName(self, name_string):
+        """Transforms a tool name like copy-info-plist to CopyInfoPlist"""
+        return name_string.title().replace("-", "")


The dynamic dispatch mechanism in Dispatch and _CommandifyName methods could potentially introduce security vulnerabilities if user input is not properly sanitized. Ensure that all methods exposed through this mechanism are intended to be accessible and consider implementing a whitelist of allowed commands.

coderabbitai · 2024-03-25T17:49:09Z

resources/language-metavariables/tree-sitter-php/build/gyp-mac-tool

+        if os.environ["XCODE_VERSION_ACTUAL"] > "0700":
+            args.extend(["--auto-activate-custom-fonts"])
+            if "IPHONEOS_DEPLOYMENT_TARGET" in os.environ:
+                args.extend(
+                    [
+                        "--target-device",
+                        "iphone",
+                        "--target-device",
+                        "ipad",
+                        "--minimum-deployment-target",
+                        os.environ["IPHONEOS_DEPLOYMENT_TARGET"],
+                    ]
+                )
+            else:
+                args.extend(
+                    [
+                        "--target-device",
+                        "mac",
+                        "--minimum-deployment-target",
+                        os.environ["MACOSX_DEPLOYMENT_TARGET"],
+                    ]
+                )
+


Manipulation of environment variables and their use in subprocess calls (e.g., args.extend with os.environ values) could potentially lead to command injection vulnerabilities. Ensure that environment variables are properly validated and sanitized before use.

coderabbitai · 2024-03-25T17:49:09Z

resources/language-metavariables/tree-sitter-php/common/define-grammar.js

+function pipeSep1(rule) {
+  return seq(rule, repeat(seq('|', rule)));
+}


Consider adding a brief comment explaining the use case for pipeSep1. While its implementation is clear, a comment could help future contributors understand its purpose more quickly, especially in the context of defining grammar rules.

+ // Creates a rule to match one or more of the rules separated by a pipe, used for defining alternatives in grammar rules. function pipeSep1(rule) { return seq(rule, repeat(seq('|', rule))); }

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

function pipeSep1(rule) {

return seq(rule, repeat(seq('|', rule)));

}

// Creates a rule to match one or more of the rules separated by a pipe, used for defining alternatives in grammar rules.

function pipeSep1(rule) {

return seq(rule, repeat(seq('|', rule)));

}

coderabbitai · 2024-03-25T17:49:09Z

...uage-metavariables/tree-sitter-php/node_modules/@eslint/eslintrc/dist/eslintrc-universal.cjs

+const RULE_SEVERITY_STRINGS = ["off", "warn", "error"],
+    RULE_SEVERITY = RULE_SEVERITY_STRINGS.reduce((map, value, index) => {
+        map[value] = index;
+        return map;
+    }, {}),
+    VALID_SEVERITIES = [0, 1, 2, "off", "warn", "error"];


The use of reduce for creating RULE_SEVERITY is correct but could be simplified for readability. Consider using an object literal directly since the mapping is static and known.

- RULE_SEVERITY = RULE_SEVERITY_STRINGS.reduce((map, value, index) => { - map[value] = index; - return map; - }, {}), + RULE_SEVERITY = { off: 0, warn: 1, error: 2 };

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

const RULE_SEVERITY_STRINGS = ["off", "warn", "error"],

RULE_SEVERITY = RULE_SEVERITY_STRINGS.reduce((map, value, index) => {

map[value] = index;

return map;

}, {}),

VALID_SEVERITIES = [0, 1, 2, "off", "warn", "error"];

const RULE_SEVERITY_STRINGS = ["off", "warn", "error"],

RULE_SEVERITY = { off: 0, warn: 1, error: 2 },

VALID_SEVERITIES = [0, 1, 2, "off", "warn", "error"];

coderabbitai · 2024-03-25T17:49:10Z

resources/language-metavariables/tree-sitter-php/node_modules/.bin/tree-sitter

@@ -0,0 +1 @@
+../tree-sitter-cli/cli.js


The script lacks a shebang line, which is essential for indicating that the script should be run with Node.js. Consider adding #!/usr/bin/env node at the top of the file.

+ #!/usr/bin/env node ../tree-sitter-cli/cli.js

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

../tree-sitter-cli/cli.js

#!/usr/bin/env node

../tree-sitter-cli/cli.js

Tip
Codebase Verification

The verification process has confirmed that neither tree-sitter nor tree-sitter.exe exists in the expected directory, aligning with the concerns raised in the review comment about the necessity of these executables for the script's functionality. This finding supports the review comment's validity.

Analysis chain

Verify the existence of the tree-sitter or tree-sitter.exe executable within the same directory as this script. This is crucial for the script's functionality, especially considering the platform-specific handling.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash # Verify the existence of tree-sitter executables relative to the script. if [ ! -f "tree-sitter" ] && [ ! -f "tree-sitter.exe" ]; then echo "Neither tree-sitter nor tree-sitter.exe exists in the expected directory." exit 1 else echo "The required executable exists." fi

Length of output: 227

coderabbitai · 2024-03-25T17:49:10Z

resources/language-metavariables/tree-sitter-php/common/scanner.h

+#define VEC_POP(vec)                                                                                                   \
+    {                                                                                                                  \
+        STRING_FREE(VEC_BACK((vec)).word);                                                                             \
+        (vec).len--;                                                                                                   \
+    }


The VEC_POP macro frees the string associated with the last element of the vector but does not explicitly nullify the pointer after freeing it. This could potentially lead to use-after-free errors if the freed memory is accessed again. It's a good practice to set pointers to NULL after freeing them to avoid such issues.

- STRING_FREE(VEC_BACK((vec)).word); + STRING_FREE(VEC_BACK((vec)).word); + VEC_BACK((vec)).word = NULL;

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

#define VEC_POP(vec) \

{ \

STRING_FREE(VEC_BACK((vec)).word); \

(vec).len--; \

}

#define VEC_POP(vec) \

{ \

STRING_FREE(VEC_BACK((vec)).word); \

VEC_BACK((vec)).word = NULL; \

(vec).len--; \

}

coderabbitai · 2024-03-25T17:49:10Z

resources/language-metavariables/tree-sitter-php/common/scanner.h

+static inline void *external_scanner_create() {
+    Scanner *scanner = calloc(1, sizeof(Scanner));
+    scanner->open_heredocs = vec_new();
+    return scanner;
+}
+
+static inline unsigned external_scanner_serialize(void *payload, char *buffer) {
+    Scanner *scanner = (Scanner *)payload;
+    return serialize(scanner, buffer);
+}
+
+static inline void external_scanner_deserialize(void *payload, const char *buffer, unsigned length) {
+    Scanner *scanner = (Scanner *)payload;
+    deserialize(scanner, buffer, length);
+}
+
+static inline bool external_scanner_scan(void *payload, TSLexer *lexer, const bool *valid_symbols) {
+    Scanner *scanner = (Scanner *)payload;
+    return scan(scanner, lexer, valid_symbols);
+}
+
+static inline void external_scanner_destroy(void *payload) {
+    Scanner *scanner = (Scanner *)payload;
+    for (size_t i = 0; i < scanner->open_heredocs.len; i++) {
+        STRING_FREE(scanner->open_heredocs.data[i].word);
+    }
+    VEC_FREE(scanner->open_heredocs)
+    free(scanner);
+}


The external_scanner_destroy function correctly frees the memory allocated for the scanner and its associated heredocs. It's good practice to ensure that all allocated memory is freed to avoid memory leaks. However, consider setting the scanner pointer to NULL after freeing it to prevent potential use-after-free errors if the scanner is accessed again after destruction.

free(scanner); + scanner = NULL;

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

static inline void *external_scanner_create() {

Scanner *scanner = calloc(1, sizeof(Scanner));

scanner->open_heredocs = vec_new();

return scanner;

}

static inline unsigned external_scanner_serialize(void *payload, char *buffer) {

Scanner *scanner = (Scanner *)payload;

return serialize(scanner, buffer);

}

static inline void external_scanner_deserialize(void *payload, const char *buffer, unsigned length) {

Scanner *scanner = (Scanner *)payload;

deserialize(scanner, buffer, length);

}

static inline bool external_scanner_scan(void *payload, TSLexer *lexer, const bool *valid_symbols) {

Scanner *scanner = (Scanner *)payload;

return scan(scanner, lexer, valid_symbols);

}

static inline void external_scanner_destroy(void *payload) {

Scanner *scanner = (Scanner *)payload;

for (size_t i = 0; i < scanner->open_heredocs.len; i++) {

STRING_FREE(scanner->open_heredocs.data[i].word);

}

VEC_FREE(scanner->open_heredocs)

free(scanner);

}

static inline void *external_scanner_create() {

Scanner *scanner = calloc(1, sizeof(Scanner));

scanner->open_heredocs = vec_new();

return scanner;

}

static inline unsigned external_scanner_serialize(void *payload, char *buffer) {

Scanner *scanner = (Scanner *)payload;

return serialize(scanner, buffer);

}

static inline void external_scanner_deserialize(void *payload, const char *buffer, unsigned length) {

Scanner *scanner = (Scanner *)payload;

deserialize(scanner, buffer, length);

}

static inline bool external_scanner_scan(void *payload, TSLexer *lexer, const bool *valid_symbols) {

Scanner *scanner = (Scanner *)payload;

return scan(scanner, lexer, valid_symbols);

}

static inline void external_scanner_destroy(void *payload) {

Scanner *scanner = (Scanner *)payload;

for (size_t i = 0; i < scanner->open_heredocs.len; i++) {

STRING_FREE(scanner->open_heredocs.data[i].word);

}

VEC_FREE(scanner->open_heredocs)

free(scanner);

scanner = NULL;

}

coderabbitai · 2024-03-25T17:49:10Z

resources/language-metavariables/tree-sitter-php/build/Makefile

+# TODO(evan): move all cross-compilation logic to gyp-time so we don't need
+# to replicate this environment fallback in make as well.
+CC.host ?= gcc
+CFLAGS.host ?= $(CPPFLAGS_host) $(CFLAGS_host)
+CXX.host ?= g++
+CXXFLAGS.host ?= $(CPPFLAGS_host) $(CXXFLAGS_host)
+LINK.host ?= $(CXX.host)
+LDFLAGS.host ?= $(LDFLAGS_host)
+AR.host ?= ar
+PLI.host ?= pli


Cross-compilation logic is mentioned to be moved to gyp-time in the future. If this is still pending, consider creating a tracking issue or adding a more detailed TODO comment to ensure this doesn't get overlooked.

Would you like me to open a GitHub issue to track the migration of cross-compilation logic to gyp-time?

coderabbitai · 2024-03-25T17:49:10Z

resources/language-metavariables/tree-sitter-php/build/Makefile

+quiet_cmd_regen_makefile = ACTION Regenerating $@
+cmd_regen_makefile = cd $(srcdir); /Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp/gyp/gyp_main.py -fmake --ignore-environment "-Dlibrary=shared_library" "-Dvisibility=default" "-Dnode_root_dir=/Users/mac/Library/Caches/node-gyp/18.5.0" "-Dnode_gyp_dir=/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp" "-Dnode_lib_file=/Users/mac/Library/Caches/node-gyp/18.5.0/<(target_arch)/node.lib" "-Dmodule_root_dir=/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php" "-Dnode_engine=v8" "--depth=." "-Goutput_dir=." "--generator-output=build" -I/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/build/config.gypi -I/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp/addon.gypi -I/Users/mac/Library/Caches/node-gyp/18.5.0/include/node/common.gypi "--toplevel-dir=." binding.gyp
+Makefile: $(srcdir)/node_modules/node-gyp/addon.gypi $(srcdir)/../../../../../../Library/Caches/node-gyp/18.5.0/include/node/common.gypi $(srcdir)/build/config.gypi $(srcdir)/binding.gyp
+	$(call do_cmd,regen_makefile)


The command for regenerating the Makefile includes hardcoded paths. Consider using variables for paths to make the build process more portable and easier to maintain.

- cmd_regen_makefile = cd $(srcdir); /Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp/gyp/gyp_main.py -fmake --ignore-environment "-Dlibrary=shared_library" "-Dvisibility=default" "-Dnode_root_dir=/Users/mac/Library/Caches/node-gyp/18.5.0" "-Dnode_gyp_dir=/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp" "-Dnode_lib_file=/Users/mac/Library/Caches/node-gyp/18.5.0/<(target_arch)/node.lib" "-Dmodule_root_dir=/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php" "-Dnode_engine=v8" "--depth=." "-Goutput_dir=." "--generator-output=build" -I/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/build/config.gypi -I/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp/addon.gypi -I/Users/mac/Library/Caches/node-gyp/18.5.0/include/node/common.gypi "--toplevel-dir=." binding.gyp + cmd_regen_makefile = cd $(srcdir); $(NODE_GYP_PATH)/gyp/gyp_main.py -fmake --ignore-environment "-Dlibrary=shared_library" "-Dvisibility=default" "-Dnode_root_dir=$(NODE_ROOT_DIR)" "-Dnode_gyp_dir=$(NODE_GYP_DIR)" "-Dnode_lib_file=$(NODE_LIB_FILE)" "-Dmodule_root_dir=$(MODULE_ROOT_DIR)" "-Dnode_engine=v8" "--depth=." "-Goutput_dir=." "--generator-output=build" -I$(CONFIG_GYPI_PATH) -I$(ADDON_GYPI_PATH) -I$(COMMON_GYPI_PATH) "--toplevel-dir=."

Consider defining the paths as variables at the top of the Makefile to improve readability and maintainability.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

quiet_cmd_regen_makefile = ACTION Regenerating $@

cmd_regen_makefile = cd $(srcdir); /Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp/gyp/gyp_main.py -fmake --ignore-environment "-Dlibrary=shared_library" "-Dvisibility=default" "-Dnode_root_dir=/Users/mac/Library/Caches/node-gyp/18.5.0" "-Dnode_gyp_dir=/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp" "-Dnode_lib_file=/Users/mac/Library/Caches/node-gyp/18.5.0/<(target_arch)/node.lib" "-Dmodule_root_dir=/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php" "-Dnode_engine=v8" "--depth=." "-Goutput_dir=." "--generator-output=build" -I/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/build/config.gypi -I/Users/mac/mnt/github/11_grit/resources/language-metavariables/tree-sitter-php/node_modules/node-gyp/addon.gypi -I/Users/mac/Library/Caches/node-gyp/18.5.0/include/node/common.gypi "--toplevel-dir=." binding.gyp

Makefile: $(srcdir)/node_modules/node-gyp/addon.gypi $(srcdir)/../../../../../../Library/Caches/node-gyp/18.5.0/include/node/common.gypi $(srcdir)/build/config.gypi $(srcdir)/binding.gyp

$(call do_cmd,regen_makefile)

quiet_cmd_regen_makefile = ACTION Regenerating $@

cmd_regen_makefile = cd $(srcdir); $(NODE_GYP_PATH)/gyp/gyp_main.py -fmake --ignore-environment "-Dlibrary=shared_library" "-Dvisibility=default" "-Dnode_root_dir=$(NODE_ROOT_DIR)" "-Dnode_gyp_dir=$(NODE_GYP_DIR)" "-Dnode_lib_file=$(NODE_LIB_FILE)" "-Dmodule_root_dir=$(MODULE_ROOT_DIR)" "-Dnode_engine=v8" "--depth=." "-Goutput_dir=." "--generator-output=build" -I$(CONFIG_GYPI_PATH) -I$(ADDON_GYPI_PATH) -I$(COMMON_GYPI_PATH) "--toplevel-dir=."

Makefile: $(srcdir)/node_modules/node-gyp/addon.gypi $(srcdir)/../../../../../../Library/Caches/node-gyp/18.5.0/include/node/common.gypi $(srcdir)/build/config.gypi $(srcdir)/binding.gyp

$(call do_cmd,regen_makefile)

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 1e9a371 and f27403d.

Files ignored due to path filters (2)

crates/wasm-bindings/wasm_parsers/tree-sitter-php.wasm is excluded by: !**/*.wasm
crates/wasm-bindings/wasm_parsers/tree-sitter-php_only.wasm is excluded by: !**/*.wasm

Files selected for processing (6)

crates/gritmodule/src/patterns_directory.rs (5 hunks)
crates/language/src/php_only.rs (1 hunks)
crates/language/src/target_language.rs (18 hunks)
crates/lsp/src/language.rs (2 hunks)
crates/wasm-bindings/src/match_pattern.rs (1 hunks)
resources/edit_grammars.mjs (4 hunks)

Files skipped from review as they are similar to previous changes (2)

crates/language/src/php_only.rs
resources/edit_grammars.mjs

Additional comments: 4

crates/lsp/src/language.rs (2)

24-24: The addition of PHP support with PatternLanguage::PhpOnly is aligned with the PR's objectives. Please ensure that "php" as a language ID is consistent with the naming conventions used across the project.

52-52: The handling of both TargetLanguage::PhpHtml and TargetLanguage::PhpOnly as "php" is appropriate for the context of language IDs. Please verify that this unified treatment does not introduce conflicts in parts of the system where distinguishing between the two PHP variants is important.

crates/gritmodule/src/patterns_directory.rs (2)

29-30: The addition of php_html and php_only BTreeMaps to the PatternsDirectory struct is a necessary step for supporting PHP patterns. Please ensure that these new fields are consistently named and used throughout the project.

116-117: Handling of PatternLanguage::PhpHtml and PatternLanguage::PhpOnly in get_language_directory_mut and related methods is crucial for PHP support. Please ensure thorough testing of the merge functionality to prevent data loss or duplication, especially given the potential overlap between PHP HTML and PHP Only patterns.

ayewo added 2 commits March 22, 2024 12:25

add git submodule tree-sitter-php

01f994b

add grammar file for parsing snippets

824b754

algora-pbc bot mentioned this pull request Mar 22, 2024

PHP language support #48

Closed

algora-pbc bot added the 🙋 Bounty claim label Mar 22, 2024

coderabbitai bot reviewed Mar 22, 2024

View reviewed changes

add a simple parse test and update submodules

75f7132

coderabbitai bot reviewed Mar 23, 2024

View reviewed changes

ayewo added 6 commits March 24, 2024 17:51

remove simple parse test

8e1483c

Merge branch 'main' of https://github.com/getgrit/gritql into feat/ad…

bf963b1

…d-php-language

add back the simple parse test after merging from main

d1fc3e1

add php and fix up file paths

cc52614

add php language-metavariables folder generated by edit_grammars.mjs

776d30c

add php dialects PhpHtml and PhpOnly

1e9a371

coderabbitai bot reviewed Mar 25, 2024

View reviewed changes

ayewo added 3 commits March 27, 2024 12:58

fix wasm parser generation for PHP

8ca02d5

add generate wasm parser

83d44e6

fix compilation now that the PHP wasm parsers are generated

f27403d

coderabbitai bot reviewed Mar 27, 2024

View reviewed changes

morgante closed this Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] feat: add php language support #53

[WIP] feat: add php language support #53

ayewo commented Mar 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 22, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot Mar 25, 2024

coderabbitai bot left a comment

	../tree-sitter-cli/cli.js
	#!/usr/bin/env node
	../tree-sitter-cli/cli.js

[WIP] feat: add php language support #53

[WIP] feat: add php language support #53

Conversation

ayewo commented Mar 22, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Mar 22, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 25, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

ayewo commented Mar 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 22, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)