Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn instead of forbid unused crate #38

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

ilevyor
Copy link
Contributor

@ilevyor ilevyor commented Mar 18, 2024

tests are compiled independently so can result in false positives when enforcing this lint, warn is sufficient to fail CI.

@ilevyor ilevyor requested a review from a team March 18, 2024 19:56
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but let's stop editing this. It's not productive.

@ilevyor ilevyor merged commit 0ca4e8b into main Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants