Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets are not loaded in modular #16

Closed
jza34 opened this issue Apr 25, 2019 · 3 comments
Closed

Assets are not loaded in modular #16

jza34 opened this issue Apr 25, 2019 · 3 comments
Labels
bug fixed

Comments

@jza34
Copy link

jza34 commented Apr 25, 2019 •
edited
Loading

Assets are not loaded in modular page... It works in default page only.
@jza34 jza34 changed the title Assets are not loaded Assets are not loaded in modular Apr 25, 2019
@rhukster
Copy link
Member

rhukster commented May 7, 2019 •
edited
Loading

Scratch that, can reproduce.. I will look at it..

rhukster added a commit that referenced this issue May 7, 2019
@rhukster
Fixed issue with OwlCarousel not initializing when cached in modular …
3b9393e 
…pages #16
@rhukster rhukster added the fixed label May 7, 2019
@gamahachaa
Copy link

Hi Andy,

PHP 7.3 Grav 1.6.8 owl 1.0.2
owl shortcode inside a modular still doesn't add the assets (works fine on regular pages).

Best

PS : I can share a dump of the site if needed

@jza34 jza34 mentioned this issue May 24, 2019
Closed
@jza34
Copy link
Author

jza34 commented May 24, 2019

Hi, and thank you because it works for me : assets are now loaded in a modular page
Grav v1.6.9
PHP-FPM v7.3.4
Shortcode Core v4.1.1
Shortcode Owl Carousel v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gamahachaa @rhukster @jza34