Allow passing arbitrary form attributes

[drzraf]

Form support for data-*or config-data-*@ parameters to be used as <form> attributes

See #173 and #293 and #294

[drzraf]

ping

[drzraf]

rebased...

[mahagr]

Some suggestions above.

[mahagr]

@drzraf We were talking about the forms today, and it looks like there's already an implementation for this for form fields, which is different to your implementation. I think it would be great if both the form and the fields used the same way instead of needing very different input from each other.

This is the code for a form field:
https://github.com/getgrav/grav-plugin-form/blob/develop/templates/forms/default/field.html.twig#L106-L110

PS: There is also support for custom attributes, but it uses yet another approach:
https://github.com/getgrav/grav-plugin-form/blob/develop/templates/forms/default/field.html.twig#L97-L101

[drzraf]

In order to move on, which implementation you advise?

[mahagr]

@rhukster We need to decide how to define attributes throughout Grav. I kind of like field.attributes approach the best:

{% if field.attributes is defined %}
  {% for attribute in field.attributes %}
    {{ attribute.name }}="{{ attribute.value|e }}"
  {% endfor %}
{% endif %}

[drzraf]

Please see latest version:

Contrary to the previous form.data.blueprints.form extraction model, blueprints-expansion is not enabled.

Eg: data-data-foo@: '\Grav\Plugin\Admin::route' would not create a data-foo='http://...' attribute.

I'd be happy if you could help getting the best of both approaches.

[mahagr]

IMHO data-*@ should work everywhere, so you can put it under attributes.

[drzraf]

I strongly share that wish, but I simply failed to find a way to do it.

[drzraf]

@rhukster : I'm really happy this got merged.
Still, I wonder: Didn't you encountered an option also preserving the blueprints-expansion feature?

[NicoHood]

@drzraf From my understanding data-attributes@: '\Grav\Plugin\Admin::route'.

It is documented here:
https://learn.getgrav.org/16/forms/blueprints/advanced-features#using-function-calls-data-at

I think the function must return a named array (dict) so we have attribute name -> value. The example uses '\Grav\Common\Page\Pages::parentsRawRoutes' maybe try this as a first test?

This new feature should be documented here:
https://learn.getgrav.org/16/forms/forms/fields-available

[NicoHood]

@drzraf did that work?

[drzraf]

Sadly no. Not with the merged commit,

1. Attributes are duplicated. Output from the form.attributes loop, then with the blueprints.form.attributes loop
2. These attributes are not expandable (no @ suffixing)