-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for cols,rows and size attribute, default type is text and label can be ommited #16
Support for cols,rows and size attribute, default type is text and label can be ommited #16
Conversation
… header it defaults to text rather failing with an obscure error message.
….name with first letter capitalised
Also added a bugfix today to this PR where the textfield name attribute appeared double in the generated output |
Support for cols,rows and size attribute, default type is text and label can be ommited
👍 |
I just saw that |
Sorry one more regards textfields. All other fields have this |
Good catch, fixed in 71c1e62 |
While working with forms I realized that the introduction of the size attribute for the input field with https://github.com/hwmaier/grav-plugin-form/commit/28b0acedea9c4c2d58bc25bc52a70467347cac98 is clashing with using size as a general css style in the form field's div wrapper. Like Maybe we should remove it again or can this be resolved somehow? What do you think? Added as issue here so it does not get forgotten: |
I added a few small additions to the form plugin which may be useful for others:
size
attribute of input fieldsrows
andcols
attribute of textfieldsaddress
becomes labelAddress
)This makes form declarations more concise as
type: text
and most trivial labels can be omitted.