Checkbox field id has dash appended

[hughbris]

I set the id property for a checkbox field in frontmatter, The field is being output with '-' appended to that id string. (Makes it difficult to select using JS DOM methods, affects label accessibility, etc.)

Looks like the checkbox template includes reference to a key Twig variable. Couldn't figure out where it's meant to be coming from, but it's empty in my case.

My guess is that that line

{% set id = field.id|default(field.name) ~ '-' ~ key %}

should be

{% set id = field.id|default(field.name ~ '-' ~ key) %}

or

{% set id = field.id|default(field.name) ~ (key ? '-' ~ key) %}

depending on what the intent and context is here. If you advise me, I'll make a PR.

Not sure if other field types are affected.

[rhukster]

I think this one: {% set id = field.id|default(field.name ~ '-' ~ key) %} is the intended approach. although key should be in index of the looping over the elements.. this is to ensure they are unique. let me take a look...

[rhukster]

Ok, i see what happened here. We added the key logic to checkboxes and it was copied to checkbox which is the singular variation. I've removed the -key logic completely for next release in this case.

[hughbris]

Fixed by eea1e45, cross referencing and closing.