Fix for Postgres connection leak bug #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update pre-commit and directions in CONTRIBUTING.md * Update CONTRIBUTING
clockworksoul
added a commit
to clockworksoul/gort
that referenced
this pull request
Jun 17, 2022
* Fix for database creation bug (getgort#183)
clockworksoul
added a commit
that referenced
this pull request
Jun 30, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Upgrade Go version and dependencies * Version fix * Ignore VS Code workspaces * Oops * Bump version in Github Actions for parity with mod file * Rm accidental file Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
clockworksoul
added a commit
that referenced
this pull request
Jul 2, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Ignore VS Code workspaces * Oops Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
clockworksoul
added a commit
that referenced
this pull request
Jul 2, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Ignore VS Code workspaces * Oops * Minor: make slice definitions idiomatic * Restore one declaration to prevent nil returns Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
clockworksoul
added a commit
that referenced
this pull request
Jul 2, 2022
* Update TODO * Minor: command help output formatting (#200) Fix help output formatting for various commands. * WIP: allow kubernetes Secrets to be injected into the worker's environment (#189) Allow kubernetes Secrets to be injected into the worker's environment (#189) * Rename config.IsDefined to simply config.Defined (#206) * Fix for Postgres connection leak bug (#208) * Fix for database creation bug (#183) * Ignore VS Code workspaces * Oops Co-authored-by: Matthew Titmus <mtitmus@yext.com> Co-authored-by: Matt Miller <msm93v2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant bug fix. The issue was traced to how transactions were being handled in the bundle code. Required a larger set of structural changes than I expected, but all seems to be working correctly now. Also added tests to detect any future regressions of this issue.
fixes #205