Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'superagent' dependency, use node https. fixes #1719 #1727

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

sriv
Copy link
Member

@sriv sriv commented Aug 26, 2020

No description provided.

Signed-off-by: sriv <srikanth.ddit@gmail.com>
@gaugebot
Copy link

gaugebot bot commented Aug 26, 2020

@sriv Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@gaugebot gaugebot bot requested a review from BugDiver August 26, 2020 17:18
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2020

Benchmark Results

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 180% 376804 0:18.33 0
c532320 182% 355644 0:20.04 0
c93f7af 179% 558492 0:33.83 0
****6e0d83f 185% 316576 0:20.36 0
c532320 188% 316540 0:20.17 0
c93f7af 182% 324672 0:20.33 0
****6e0d83f 178% 394976 0:20.54 0
c532320 178% 374068 0:20.26 0
c93f7af 166% 639544 0:30.80 0
****6e0d83f 181% 397856 0:13.15 0
c532320 174% 384524 0:13.73 0
c93f7af 174% 385536 0:14.13 0
****6e0d83f 179% 388428 0:21.85 0
c532320 177% 349640 0:21.11 0
c93f7af 166% 619168 0:33.39 0
****6e0d83f 184% 318832 0:21.98 0
c532320 184% 340820 0:20.92 0
c93f7af 158% 341744 0:31.93 0
****6e0d83f 181% 318024 0:17.65 0
c532320 181% 338348 0:18.11 0
c93f7af 147% 296200 0:30.25 0
****6e0d83f 183% 355184 0:23.08 0
c532320 183% 303728 0:22.61 0
c93f7af 153% 362648 0:37.51 0
****6e0d83f 179% 351068 0:13.29 0
c532320 170% 343216 0:14.42 0
c93f7af 163% 341344 0:15.11 0
908785e 173% 350860 0:16.22 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@NivedhaSenthil NivedhaSenthil merged commit 82b07e1 into getgauge:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants