Fix build for Ruby 2.7+ and add arm64 variants #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
master
branch
2 times, most recently
from
8c72d79 to
dcc55a2
Compare
This was referenced Jun 27, 2023
sriv
requested changes
Jun 27, 2023
Also - upgrades golang to latest (1.20.x). 1.13 is ancient and cannot build for arm64 on most platforms. Newer versions have dropped 32-bit support for some platforms as well. - Corrects builds/tests to work against modern Go - Upgrades most other dependencies - Fixes issue with Windows builds running wrong commit version Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
gauge-ruby 0.5.4 does seem to work fine on Ruby 2.7 through 3.2, however use of some language features might not work properly between specs and implementations, and the dependency ranges may prevent folks from upgrading other tools (e.g rubocop) Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
chadlwilson
force-pushed
the
master
branch
2 times, most recently
from
6ca081f to
7faaf93
Compare
gauge-ruby has been licensed under Apache 2.0 since 2020 in getgauge#182 Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
Runtime usage of this appears to have been removed a long time ago, seems only used in tests now. Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
chadlwilson
added
enhancement
major
dependencies
|
@chadlwilson Thank you for contributing to gauge-ruby. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
sriv
approved these changes
Jun 28, 2023
chadlwilson
added a commit
to getgauge/gauge-repository
that referenced
this pull request
Jun 28, 2023
…builds and removal of x86 See getgauge/gauge-ruby#290 Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
Fixes #289
This PR's main goal was to add arm64 builds of the gems.
However there was a lot of cruft required to get there, so it
2.7.x, which is recently EOL.3.0to3.2or at least not cause issues with other Gems that useparserandunparserosdependency from runtime usage1.13->1.20.5for security reasons, and to support arm64 builds.main()files in same package)Apologies for the big joined together first commit which does multiple things. I can probably break it apart into the "fix build" stuff and the "add arm64+upgrade golang" stuff if valuable.