Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose logging even when log level is info #135

Closed
rogerjak opened this issue Nov 27, 2020 · 9 comments
Closed

Verbose logging even when log level is info #135

rogerjak opened this issue Nov 27, 2020 · 9 comments

Comments

@rogerjak
Copy link

Since 0.3.0 the console output and log file is filled with these:
Microsoft.AspNetCore.Routing.EndpointMiddleware[0]
Microsoft.AspNetCore.Hosting.Diagnostics[1]
For each one there are a couple of more rows belonging to them.
I don't think they should be there for log level info, only debug.

sriv added a commit that referenced this issue Dec 2, 2020
fixes #135

Signed-off-by: sriv <srikanth.ddit@gmail.com>
@sriv
Copy link
Member

sriv commented Dec 2, 2020

thanks for raising this. gauge-dotnet 0.3.0 uses a pure c# gRPC implementation, which in turn uses the asp-net core libs to host the server.

Raised a fix for this.

@sriv
Copy link
Member

sriv commented Dec 2, 2020

Just realized that #132 is also related.

@raweaver
Copy link
Contributor

raweaver commented Jan 4, 2021

I've noticed similar behavior with gauge-dotnet 0.3.1 where the Microsoft.AspNetCore info messages appear in the console output on a normal run.

# Specification Heading
info
: Microsoft.AspNetCore.Hosting.Diagnostics[1]
Request starting HTTP/2 POST http://127.0.0.1:54594/gauge.messages.Runner/InitializeSpecDataStore application/grpc
info: Microsoft.AspNetCore.Routing.EndpointMiddleware[0]
Executing endpoint 'gRPC - /gauge.messages.Runner/InitializeSpecDataStore'
info
: Microsoft.AspNetCore.Routing.EndpointMiddleware[1]
Executed endpoint 'gRPC - /gauge.messages.Runner/InitializeSpecDataStore'
info: Microsoft.AspNetCore.Hosting.Diagnostics[2]
Request finished in 1.6942ms 200 application/grpc
info
: Microsoft.AspNetCore.Hosting.Diagnostics[1]
Request starting HTTP/2 POST http://127.0.0.1:54594/gauge.messages.Runner/StartSpecExecution application/grpc

I then set GAUGE_LOG_LEVEL = DEBUG in my environment and the Microsoft.AspNetCore logging statements did not appear in the console output. This is counterintuitive that the additional logging output is suppressed when enabling debug logging level.

I would appreciate any help in resolving this.

Thank you!

@zabil
Copy link
Member

zabil commented Jan 4, 2021

This should be fixed in 0.3.1 via

https://github.com/getgauge/gauge-dotnet/pull/133/files#diff-280ecf7c70e274bad023c9acea61103fae54640ec4fdc58b35dd6ff40d199e74L41-L43

Can you please the dotnet plugin is using the latest version?

@raweaver
Copy link
Contributor

raweaver commented Jan 4, 2021

@zabil Thank you for the quick response. You are correct, this is fixed in 0.3.1. My apologies. I thought I was running 0.3.1 because I ran gauge update dotnet, but the update had installed 0.3.0.

How does 0.3.1 become the version installed when gauge checks for plugin updates?

Thank you!

@zabil
Copy link
Member

zabil commented Jan 4, 2021

Ok that explains it and thanks for pointing it out. For some reason the latest plugin version is not updated here

https://github.com/getgauge/gauge-repository/blob/master/dotnet-install.json#L4

Need to check that and will push a fix soon.

@rogerjak
Copy link
Author

Ok that explains it and thanks for pointing it out. For some reason the latest plugin version is not updated here

https://github.com/getgauge/gauge-repository/blob/master/dotnet-install.json#L4

Need to check that and will push a fix soon.

Gauge 1.1.7 still won't update dotnet to 0.3.1... :(

@zabil
Copy link
Member

zabil commented Jan 20, 2021

0.3.1 is available at https://github.com/getgauge/gauge-dotnet/releases/tag/v0.3.1

However it's not updated at https://github.com/getgauge/gauge-repository/blob/fa99e41a4afd6a03f21f4ec456aeb789f6352bfc/dotnet-install.json#L4

Please feel free to send a pull request by copying the section related to 0.3.0 and bumping up the version and the download urls to 0.3.1. You just need to make sure that it's a valid json file.

@sriv
Copy link
Member

sriv commented Jan 22, 2021

gauge-dotnet 0.3.1 is added to the repository via getgauge/gauge-repository#63

Am closing this issue, please feel free to comment if this isn't fixed in 0.3.1.

@sriv sriv closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants