Add support for stabby in Bytes and TaggedOption #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-avital
commented
Jun 26, 2024
| @@ -1,4 +1,26 @@ | |||
| pub use stabby::*; | |||
There was a problem hiding this comment.
I removed this, let's avoid having my majors force majors in safer_ffi
| @@ -141,7 +141,7 @@ paste.version = "1.0.12" | |||
| scopeguard.version = "1.1.0" | |||
| scopeguard.default-features = false | |||
|
|
|||
| stabby.version = "5.1.0" | |||
There was a problem hiding this comment.
As you suggested, I edited SemVer Prime to not have the -1 to help with factorization :p
There was a problem hiding this comment.
Nice! Good catch on the public-semver dependency on stabby, I don't think safer-ffi is currently able to follow SemVer Prime™
- My main review of this PR is regarding the
cfg-duplicatedfnsignatures: since docs.rs (which is what I prefer to favor) does not allow multiple "renders" of its docs, I'd rather havecfg-agnostic docs, and at that point, move thecfgswitchs inside thefnbody if the signature does not change 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.