Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Box<[u8]> and Vec<u8> to safer_ffi::bytes::Bytes #216

Merged
merged 2 commits into from
May 29, 2024

Conversation

p-avital
Copy link
Contributor

No description provided.

@p-avital p-avital force-pushed the pa/bytes-from-vec branch from 530a127 to 9156d68 Compare May 29, 2024 19:18
Copy link
Collaborator

@danielhenrymantilla danielhenrymantilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

  • some nits, and the : Sync typo, but nothing major. Merge whenever you want

src/bytes.rs Outdated Show resolved Hide resolved
src/bytes.rs Outdated Show resolved Hide resolved
src/bytes.rs Outdated Show resolved Hide resolved
src/bytes.rs Outdated Show resolved Hide resolved
src/bytes.rs Show resolved Hide resolved
src/bytes.rs Outdated Show resolved Hide resolved
src/bytes.rs Outdated Show resolved Hide resolved
src/bytes.rs Outdated Show resolved Hide resolved
@p-avital p-avital enabled auto-merge (squash) May 29, 2024 19:31
@p-avital p-avital merged commit da13fcc into master May 29, 2024
110 checks passed
@p-avital p-avital deleted the pa/bytes-from-vec branch May 29, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants