-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Exclude examples/point from workspace #212
π Exclude examples/point from workspace #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! β
@@ -171,6 +171,7 @@ members = [ | |||
"napi-dispatcher/wasm/src/proc_macros", | |||
"safer-ffi-build", | |||
] | |||
exclude = ["examples/point"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exclude = ["examples/point"] |
This can also be achieved by adding:
[workspace]
at the end of examples/point/Cargo.toml
, which I personally prefer as it's about examples/point
"seeing itself out" π
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [clap](https://togithub.com/clap-rs/clap) | dependencies | patch | `4.5.11` -> `4.5.13` | | [dunce](https://lib.rs/crates/dunce) ([source](https://gitlab.com/kornelski/dunce)) | dev-dependencies | patch | `1.0.4` -> `1.0.5` | | [regex](https://togithub.com/rust-lang/regex) | dependencies | patch | `1.10.5` -> `1.10.6` | | [ros2-client](https://atostek.com/en/products/rustdds/) ([source](https://togithub.com/jhelovuo/ros2-client)) | dependencies | patch | `0.7.2` -> `0.7.3` | | [rustdds](https://atostek.com/en/products/rustdds/) ([source](https://togithub.com/jhelovuo/RustDDS)) | dependencies | patch | `0.10.1` -> `0.10.3` | | [safer-ffi](https://togithub.com/getditto/safer_ffi) | dependencies | patch | `0.1.9` -> `0.1.12` | | [serde_json](https://togithub.com/serde-rs/json) | dependencies | patch | `1.0.121` -> `1.0.122` | --- ### Release Notes <details> <summary>clap-rs/clap (clap)</summary> ### [`v4.5.13`](https://togithub.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#4513---2024-07-31) [Compare Source](https://togithub.com/clap-rs/clap/compare/v4.5.12...v4.5.13) ##### Fixes - *(derive)* Improve error message when `#[flatten]`ing an optional `#[group(skip)]` - *(help)* Properly wrap long subcommand descriptions in help ### [`v4.5.12`](https://togithub.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#4512---2024-07-31) [Compare Source](https://togithub.com/clap-rs/clap/compare/v4.5.11...v4.5.12) </details> <details> <summary>kornelski/dunce (dunce)</summary> ### [`v1.0.5`](https://gitlab.com/kornelski/dunce/compare/v1.0.4...v1.0.5) [Compare Source](https://gitlab.com/kornelski/dunce/compare/v1.0.4...v1.0.5) </details> <details> <summary>rust-lang/regex (regex)</summary> ### [`v1.10.6`](https://togithub.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#1106-2024-08-02) [Compare Source](https://togithub.com/rust-lang/regex/compare/1.10.5...1.10.6) \=================== This is a new patch release with a fix for the `unstable` crate feature that enables `std::str::Pattern` trait integration. Bug fixes: - [BUG #​1219](https://togithub.com/rust-lang/regex/pull/1219): Fix the `Pattern` trait implementation as a result of nightly API breakage. </details> <details> <summary>jhelovuo/ros2-client (ros2-client)</summary> ### [`v0.7.3`](https://togithub.com/jhelovuo/ros2-client/compare/0.7.2...0.7.3) [Compare Source](https://togithub.com/jhelovuo/ros2-client/compare/0.7.2...0.7.3) </details> <details> <summary>jhelovuo/RustDDS (rustdds)</summary> ### [`v0.10.3`](https://togithub.com/jhelovuo/RustDDS/compare/0.10.2...0.10.3) [Compare Source](https://togithub.com/jhelovuo/RustDDS/compare/0.10.2...0.10.3) ### [`v0.10.2`](https://togithub.com/jhelovuo/RustDDS/compare/0.10.1...0.10.2) [Compare Source](https://togithub.com/jhelovuo/RustDDS/compare/0.10.1...0.10.2) </details> <details> <summary>getditto/safer_ffi (safer-ffi)</summary> ### [`v0.1.12`](https://togithub.com/getditto/safer_ffi/releases/tag/v0.1.12) [Compare Source](https://togithub.com/getditto/safer_ffi/compare/v0.1.11...v0.1.12) #### What's Changed - Fix `Bytes`' `ReprC` impl, as `vtable` is not necessarily aligned by [@​p-avital](https://togithub.com/p-avital) in [https://github.com/getditto/safer_ffi/pull/235](https://togithub.com/getditto/safer_ffi/pull/235) **Full Changelog**: getditto/safer_ffi@v0.1.11...v0.1.12 ### [`v0.1.11`](https://togithub.com/getditto/safer_ffi/releases/tag/v0.1.11) [Compare Source](https://togithub.com/getditto/safer_ffi/compare/v0.1.10...v0.1.11) #### What's Changed - Upgrade stabby to 36.1.1 by [@​p-avital](https://togithub.com/p-avital) in [https://github.com/getditto/safer_ffi/pull/234](https://togithub.com/getditto/safer_ffi/pull/234) **Full Changelog**: getditto/safer_ffi@v0.1.10...v0.1.11 ### [`v0.1.10`](https://togithub.com/getditto/safer_ffi/releases/tag/v0.1.10) [Compare Source](https://togithub.com/getditto/safer_ffi/compare/v0.1.9...v0.1.10) #### What's Changed - Add ability to emit type aliases to C headers by [@​danielhenrymantilla](https://togithub.com/danielhenrymantilla) in [https://github.com/getditto/safer_ffi/pull/228](https://togithub.com/getditto/safer_ffi/pull/228) - Fix FFI typedef pattern not supporting generics by [@​danielhenrymantilla](https://togithub.com/danielhenrymantilla) in [https://github.com/getditto/safer_ffi/pull/229](https://togithub.com/getditto/safer_ffi/pull/229) - π Exclude examples/point from workspace by [@​phatblat](https://togithub.com/phatblat) in [https://github.com/getditto/safer_ffi/pull/212](https://togithub.com/getditto/safer_ffi/pull/212) - `raw_const` addition to `#[ffi_export]`-ed `const`s for SWIG compat by [@​danielhenrymantilla](https://togithub.com/danielhenrymantilla) in [https://github.com/getditto/safer_ffi/pull/230](https://togithub.com/getditto/safer_ffi/pull/230) - \[β οΈ technically breaking] Add interning to `Bytes`, reducing the need for allocations when slices are small. by [@​p-avital](https://togithub.com/p-avital) in [https://github.com/getditto/safer_ffi/pull/231](https://togithub.com/getditto/safer_ffi/pull/231) - Despite this being a technically breaking change, API-wise (`Bytes : From<&'static [u8]>` rather than `From<&'any [u8]>`), and ABI-wise (`Bytes`' `.vtable` pointer can now be an ill-alligned odd address representing the bit-tagging of its now added inlined-bytes representation), both of these cases are small enough, and `0.1.9` has been out for enough of a short time, not to warrant a major bump. `0.1.9` will be yanked in a couple weeks. - Add convenience release scripts by [@​danielhenrymantilla](https://togithub.com/danielhenrymantilla) in [https://github.com/getditto/safer_ffi/pull/232](https://togithub.com/getditto/safer_ffi/pull/232) **Full Changelog**: getditto/safer_ffi@v0.1.9...v0.1.10 </details> <details> <summary>serde-rs/json (serde_json)</summary> ### [`v1.0.122`](https://togithub.com/serde-rs/json/releases/tag/v1.0.122) [Compare Source](https://togithub.com/serde-rs/json/compare/v1.0.121...v1.0.122) - Support using `json!` in no-std crates ([#​1166](https://togithub.com/serde-rs/json/issues/1166)) </details> --- ### Configuration π **Schedule**: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π» **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/dora-rs/dora). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Running the suggested
make
command in theexamples/point
subdir resulted in the following error:In this PR I've excluded
example/point
from the workspace and ignored itsCargo.lock
so that it doesn't need to be updated.If it would make more sense to include the example in the workspace, I can rework this to do that instead.