Use external DittoPresenceViewerCore dependency #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplattenburg
force-pushed
the
BP/extract_presence_viewer
branch
from
36e7fd5 to
8f85300
Compare
|
This will now depend on getditto/DittoPresenceViewerCore#5 and a matching new release of the new package to avoid undoing the work in #167. Marking as a draft for now. |
bplattenburg
commented
Jan 3, 2025
bplattenburg
changed the title
bplattenburg
commented
Jan 3, 2025
| // MARK: Constants | ||
|
|
||
| private struct LocalizedStrings { | ||
| static let title = NSLocalizedString("Ditto Presence", |
There was a problem hiding this comment.
We don't actually have any matching localized strings (or any at all in the package), and I was getting some inconsistent build errors from Xcode 16.2 around the Bundle+FrameworkBundle.swift code - removing this single usage allowed me to remove that extension as well.
|
This now depends on getditto/DittoPresenceViewerCore#7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use the presence viewer from its own repo / package as part of the path to a single source of truth for the presence viewer's web code (JS & HTML). All the Swift code stays here.
Depends on getditto/DittoPresenceViewerCore#7
Closes CXTOOLS-358
Part of CXTOOLS-337